Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for new owner(s)/maintainer(s) #833

Open
alexander-akait opened this issue Nov 7, 2019 · 18 comments
Open

Looking for new owner(s)/maintainer(s) #833

alexander-akait opened this issue Nov 7, 2019 · 18 comments
Assignees

Comments

@alexander-akait
Copy link
Member

Hi all,

Unfortunately, recently there is not enough time to support the project. I’m afraid that I’ll be able to find time in the near future, it doesn’t mean that I want to leave the project forever, it means that I don’t have time in near future.

Minification is an important part of web application and we often neglect her. Unfortunately, despite the high popularity of the package and its use, very few developers help to maintenance the project. So now I need you ❤️ .

Some ideas from my head for future works:

CSS-in-JS 🥇

Many may notice that in recent years CSS-in-JS has been gaining popularity. Does that mean for cssnano dead? No! We can and we need to reduce and optimize CSS-in-JS. For example stylelint support linting CSS-in-JS out of box and that means we can optimize CSS-in-JS too.

Bundlers and boilerplates (performance) 🐎

There is still no official plugin cssnano webpack plugin. We could use parallelization and cache to speed up project builds. It can be implemented on the cssnano side so parcel get speed up too!

I can help with that ⭐

Future PostCSS and cssnano ❤️

Many developers know what we use the PostCSS (https://github.com/postcss/postcss) for parsing CSS. This means that you will get a good experience with PostCSS. You can fix problems and improve this great tool. For example postcss/postcss#1145 and postcss/postcss#1299 still not solved and it is you who can help with this.

I will help you and advise how best to solve problems or make improvements as reviewer.

So who's interested?

@anikethsaha
Copy link
Member

anikethsaha commented Nov 7, 2019

I can provide some help. Although need some time with getting the core codebase but definitely I can help here.

@ben-eb
Copy link
Collaborator

ben-eb commented Nov 7, 2019

@evilebottnawi Thanks for all of your hard work. 👍

@JohnTitor
Copy link

@evilebottnawi Hi, thanks for the work! I'd like to get involved in cssnano and help some work.

@alexander-akait
Copy link
Member Author

@JohnTitor thanks! I would like to see a few PRs (fixes/improvements) to see you level and answer questions that arise while you work ⭐

@alexander-akait
Copy link
Member Author

/cc @anikethsaha Can you write me to DM in twitter? I don't ignore you, just don't have time right now

@anikethsaha
Copy link
Member

/cc @anikethsaha Can you write me to DM in twitter? I don't ignore you, just don't have time right now

I lost my old twitter account 😅

I will DM you from new one 👍

@jonathantneal
Copy link

Hey @anikethsaha, @evilebottnawi, may I help? For this project specifically, I’d like to work with @Timer to publish some merged bug fixes yet published. @Timer may be able to set up the repo infrastructure to do automated releases.

My hope is that this helps folks by cutting a fresh release and then easing maintenance going forward.

If that’s acceptable, please let me know if/when we can get started.

As for “Future PostCSS and cssnano” I’m working on an updated parser that would cover everything in the selector and value parsers.

@anikethsaha
Copy link
Member

I think the automated release will be really helpful.

Also, a WIP nightly release is in progress, https://github.com/cssnano/cssnano-nightly (I didn't push the code , I will do it soon.)

@anikethsaha
Copy link
Member

Let me know if you need anything from my end

@jonathantneal
Copy link

I’d need permissions:

  • ability to access both GH repo and NPM repo(s). we can work as tightly as you’d like on this.
  • ability to set up branch protection.
  • ability to enforce PR naming conventions (so that the maintenance can be truly hands off / community driven).
  • ability to give Joe (timer) these permissions and track things (because I feel responsible for seeing this through).
  • ability to add/edit the projects tab so I can document all the things we do.

☝️ For posterity, please know that all the best ideas here are Joe’s. I’m practically the middleman, so you could skip past me if you prefer. I mostly want permissions so that I can provide oversight, get Joe what they need when they need it, and so that I can document everything we do.

@anikethsaha
Copy link
Member

  • ability to access both GH repo and NPM repo(s). we can work as tightly as you’d like on this.

I only have the GH repo permission, not the NPM access.
I am +1 for giving the permission to you guys. cc @evilebottnawi

  • ability to set up branch protection.

this is a good idea. I think once the automation for the release is completed, we can set up the protection to the master branch.
Though two approvals for a PR to merge is recommended and optimal. But as non-availability of maintainers, I think we can have one approval merging as well. (cause I think I will be available mostly for review.)

  • ability to enforce PR naming conventions (so that the maintenance can be truly hands off / community driven).

100% agreed. I am using angular commit conventions for this (and my other ) repo(s).
Happy to add a commit linter or bot to validate that.

  • ability to give Joe (timer) these permissions and track things (because I feel responsible for seeing this through).

No issue from my side as mentioned above.

  • ability to add/edit the projects tab so I can document all the things we do.

Cool.

cc @evilebottnawi your thoughts. ?

@alexander-akait
Copy link
Member Author

@jonathantneal I sent invite you (owner) and Joe (member), you can grant more access to other developers if you find it necessary (for @Timer and @anikethsaha)

@anikethsaha Now you are member of org

@jonathantneal You have access to publish new version to npm, if you want to adding more developers, feel free to do it

Something else?

@clshortfuse
Copy link
Contributor

I'll bite. There is some maintainability issues with the code though. Not much of the code itself has documentation. I have had good success with eslint with airbnb-base, jsdoc/recommended, and @typescript-eslint/recommended. That doesn't require moving to Typescript. It just uses Typescript to ensure you're not calling the wrong functions on stuff.

I'm working on implementing support for non-adjacent rules, but somethings are a bit confusing. So, I've started using these eslint rules and add documentation to everything in hopes of making the code more understandable. I'll submit a PR for you all to see at a later date.

@alexander-akait
Copy link
Member Author

Pr welcome

@tannerdolby
Copy link

@alexander-akait I might be a bit late to the party here, but I am happy to help out with any remaining bugs/issues. Let me know if y'all still need any extra help. Thanks!

@alexander-akait
Copy link
Member Author

alexander-akait commented May 5, 2023

@tannerdolby Big thank you, feel free to take any issue and send a PR, we don't have "big plan" what we will do next, just bug fixes and improve our minification, if you need help with something, just ping me and I will help

@ludofischer
Copy link
Collaborator

@tannerdolby if you're interested in a challgenge, we have a bunch of longstanding bugs that get reported again and again: sometime ago I have grouped them into three projects: merge-longhand, merge-rules and postcss-calc. postcss-calc is less urgent because we now catch the exceptions that the parser throws, so the calc() expression is left untouched instead of crashing the whole process. For merge-rules, we were planning on sorting the rules before attempting to merge them instead of sorting at the end. merge-longhand is the trickiest, it handles neither borders nor css variables correctly.

@tannerdolby
Copy link

@alexander-akait You're welcome! Okay cool, sounds good. I'll make sure to reachout if I need help with anything.

@ludofischer Thanks for the heads up and for providing some context around the higher priority issues. I'm definitely interested in helping out wherever is most useful so I will start taking a look at the bugs grouped into the three projects you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants