Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] : animation referencing name starts with e + number is minized to NaN #958

Closed
fa93hws opened this issue Oct 19, 2020 · 2 comments
Closed

[Bug] : animation referencing name starts with e + number is minized to NaN #958

fa93hws opened this issue Oct 19, 2020 · 2 comments
Labels
duplicate upstream
Milestone
5.0.0

Comments

@fa93hws
Copy link

fa93hws commented Oct 19, 2020

Describe the bug

.e4yw0Q {
    animation: e4yw0Q;
}

@keyframes e4yw0Q {}

leads to
.e4yw0Q{animation:NaNyw0Q}
(It should not be NaN)

To Reproduce
https://cssnano.co/playground/#eyJpbnB1dCI6Ii5lNHl3MFEge1xuICAgIGFuaW1hdGlvbjogZTR5dzBRO1xufVxuXG5Aa2V5ZnJhbWVzIGU0eXcwUSB7fVxuXG4iLCJjb25maWciOiIvLyBjc3NuYW5vIGNvbmZpZ1xue1xuICBcInByZXNldFwiIDogXCJkZWZhdWx0XCJcbn1cbiJ9

Expected behavior
It should be .e4yw0Q{animation:e4yw0Q}
@anikethsaha
Copy link
Member

Thanks for the issue

Duplicate #909

@anikethsaha anikethsaha linked a pull request Oct 23, 2020 that will close this issue
Bump postcss-values-replace #941
Closed
SkReD added a commit to SkReD/cssnano that referenced this issue Oct 23, 2020
@SkReD
fix(postcss-convert-values): add test case for cssnano#958
5d98f96
SkReD added a commit to SkReD/cssnano that referenced this issue Oct 23, 2020
@SkReD
fix(postcss-convert-values): add test case for cssnano#958
5ad05d2
@ludofischer ludofischer added this to the 5.0.0 milestone Mar 9, 2021
@ludofischer
Copy link
Collaborator

Fixed in 5.0.0-rc.2

ludofischer pushed a commit that referenced this issue Apr 26, 2021
@SkReD @ludofischer
test(postcss-convert-values): add test case for #958
afbccfa
ludofischer pushed a commit that referenced this issue Apr 26, 2021
@SkReD @ludofischer
test(postcss-convert-values): add test case for #958
2dc2ffd
ludofischer added a commit that referenced this issue Apr 28, 2021
@ludofischer @SkReD
Add tests for fixed edge cases (#1059)
e64272f 
* test(postcss-merge-longhand): check invalid border property handling

* test(postcss-convert-values): add test case for #958

Co-authored-by: Shipov Mikhail <mshipov@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate upstream
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Bump postcss-values-replace SkReD/cssnano
3 participants
@ludofischer @fa93hws @anikethsaha