Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch entries scroll-timeline-axis and scroll-timeline-name are properties, not types #221

Open
pyoor opened this issue Dec 15, 2022 · 3 comments

Comments

@pyoor
Copy link

pyoor commented Dec 15, 2022

Maybe I'm not fully understanding the purpose of these patch entries, but scroll-timeline-axis and scroll-timeline-name are properties, not types. I don't see mdn/data referencing either of these so I'm not sure exactly why they are included in the patch. If you're just adding entries that are missing, you may as well include scroll-timeline as well.

csstree/data/patch.json

Lines 654 to 664 in 593bf37

"scroll-timeline-axis": {
"comment": "missed definition",
"syntax": "block | inline | vertical | horizontal"
},
"scroll-timeline-name": {
"comment": "missed definition",
"references": [
"https://w3c.github.io/csswg-drafts/scroll-animations/#propdef-scroll-timeline-name"
],
"syntax": "none | <custom-ident>"
},

@pyoor pyoor changed the title scroll-timeline-axis and scroll-timeline-name are properties, not types Patch entries scroll-timeline-axis and scroll-timeline-name are properties, not types Dec 15, 2022
@pyoor
Copy link
Author

pyoor commented Dec 15, 2022

My mistake. I was looking at an outdated version of mdn data. I made a PR for this upstream.

mdn/data#631

@pyoor pyoor closed this as completed Dec 15, 2022
@pyoor pyoor reopened this Dec 15, 2022
@pyoor
Copy link
Author

pyoor commented Dec 15, 2022

These should probably be removed once that PR lands.

@lahmatiy
Copy link
Member

@pyoor You're right, it should contain a references to properties not types. I fixed the patch in CSSTree. However, the syntax definitions for <scroll-timeline-name> and <scroll-timeline-axis> properties was changed. I left a comment in your PR to mdn/data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants