Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oklch() support #244

Open
ai opened this issue Feb 9, 2023 · 6 comments
Open

oklch() support #244

ai opened this issue Feb 9, 2023 · 6 comments

Comments

@ai
Copy link

ai commented Feb 9, 2023

This code

.block {
  background: oklch(0% 0 0);
}

Throws an error in declaration-property-value-no-unknown rule in Stylelint 15:

Unexpected unknown value "oklch(" for property "background"

Seems like we need to add oklch() (and maybe other functions from CSS Color 4) to csstree.

oklch() is already working in Safari, upcoming Chrome 111 and Firefox Nightly.

@ai
Copy link
Author

ai commented Feb 9, 2023

I send PR to mdn/data mdn/data#642

@ai
Copy link
Author

ai commented Feb 15, 2023

@lahmatiy my PR to mdn/data was merged, but after pnpm update I still have an issue.

Do we need to release csstree?

@lahmatiy
Copy link
Member

Yes, since mdn/data is pinned in css-tree (because it breaks syntaxes time to time). But the problem is that mdn/data doesn't published a new version with your changes yet.

@Mouvedia
Copy link

Mouvedia commented Oct 16, 2023

@ai
Copy link
Author

ai commented Nov 6, 2023

@Mouvedia no, declaration-property-value-no-unknown still doesn’t work https://github.com/logux/stylelint-config/actions/runs/6767060071/job/18389092890

@lahmatiy do we need to release a new csstree version with these mdn-data changes?

@shellscape
Copy link

@ai seems there are a number of fixes on main that need releasing as well. @lahmatiy would be great to get a new version published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants