Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about delay #399

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Remove note about delay #399

merged 1 commit into from
Jan 14, 2020

Conversation

nickmeldrum
Copy link
Contributor

At this point in the tutorial we aren't using the basket service that has this delay, so this note is unnecessary, potentially confusing?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
At this point in the tutorial we aren't using the basket service that has this delay, so this note is unnecessary, potentially confusing?
@ctrlplusb
Copy link
Owner

Woot! Contributing now too. 💜

Total convert. 😝

@ctrlplusb ctrlplusb merged commit 9735748 into ctrlplusb:master Jan 14, 2020
@nickmeldrum
Copy link
Contributor Author

😎

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #399 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #399   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files          20       20           
  Lines         565      565           
  Branches      104      104           
=======================================
  Hits          553      553           
  Misses         10       10           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f13d5...fd8c56e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants