Skip to content
This repository has been archived by the owner on Feb 12, 2019. It is now read-only.

Images won't appear in Safari browser #275

Open
RebeccaMichelleK opened this issue Nov 30, 2017 · 6 comments
Open

Images won't appear in Safari browser #275

RebeccaMichelleK opened this issue Nov 30, 2017 · 6 comments

Comments

@RebeccaMichelleK
Copy link

Hello All,
I am trying to push to production and have noticed a bug. When I am in Safari, the images in the notification aren't in the notification. I am testing on an iPhone 6 Plus and have IOS 11. Also, I can't test it because I can't get the notification to reappear after I close it. I have tried clearing my cache, but that hasn't worked. The disappearing act is happening for both Safari and Chrome.

Do you have any suggestions on how to fix the image issue and make the notification reappear for testing?

Any help will be greatly appreciated!

Thanks!
Rebecca

@damonholzborn
Copy link

The solution is available in this pull request:
#270

The fix just updates the CSS to add iOS 11.

.ath-ios8.ath-tablet,
.ath-ios9.ath-tablet,
.ath-ios10.ath-tablet{
...
}

Becomes ->>

.ath-ios8.ath-tablet,
.ath-ios9.ath-tablet,
.ath-ios10.ath-tablet,
.ath-ios11.ath-tablet{
...
}

and

.ath-ios7 .ath-action-icon,
.ath-ios8 .ath-action-icon,
.ath-ios9 .ath-action-icon,
.ath-ios10 .ath-action-icon,
.ath-ios10 .ath-action-icon{
...
}

Becomes ->>

.ath-ios7 .ath-action-icon,
.ath-ios8 .ath-action-icon,
.ath-ios9 .ath-action-icon,
.ath-ios10 .ath-action-icon,
.ath-ios10 .ath-action-icon,
.ath-ios11 .ath-action-icon{
...
}

@damonholzborn
Copy link

You can make the notification reappear on your phone by plugging in your phone to your computer and selecting it in the Develop menu in Safari. In the Web Inspector that opens for your phone on your computer, select Local Storage in the left column of the Storage tab of the Web Inspector. From there you can delete the org.cubiq.addtohome row of local storage by selecting it and pressing the delete key. When you reload, it should appear again, per your settings.

@RebeccaMichelleK
Copy link
Author

That worked! Thanks for the help!

@Amunette
Copy link

Hi,
The action-icon is still missing in the notification.
Is there anything else to do? Unfortunately this update to css doesn't seem to work for me.
I'm using iPhone 6 Plus and iOS 11.2.2
I also have to use jQuery mobile 1.4.5 ..

@davidjnelson
Copy link

the code in #270 works great! makes the action icon appear.

@meloc
Copy link

meloc commented Jun 18, 2018

Worked for me too, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants