Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review step wording #549

Open
2 tasks
mvz opened this issue Mar 6, 2018 · 2 comments
Open
2 tasks

Review step wording #549

mvz opened this issue Mar 6, 2018 · 2 comments
Labels
user experience
Milestone
2.3.0

Comments

@mvz
Copy link
Contributor

mvz commented Mar 6, 2018 •
edited

Summary

Go over the wording of the cucumber steps and make it nicer.

Context & Motivation

Some wording is a little inconsistent or unclear. We should improve it and deprecate the bad old wording. As a follow-up, the bad wording can be removed in a major version.

Details

(I'm going to collect bad wording below):

  • Change 'the specs should not pass with' to 'the specs should fail with' to make it clear that the given doc string will be the expected output. With the current wording, it seems like passing with different output would satisfy the step. Variants for features should also be updated
  • ...
@mvz mvz added this to the 1.0.0-alpha.3 milestone Mar 6, 2018
@stale
Copy link

stale bot commented May 5, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the stale These issues were closed by stalebot and need to be reviewed to see if they're still relevant. label May 5, 2018
@xtrasimplicity xtrasimplicity removed the stale These issues were closed by stalebot and need to be reviewed to see if they're still relevant. label May 6, 2018
@mvz mvz modified the milestones: 1.0.0-alpha.3, 1.1.0 Jun 16, 2019
@mvz mvz changed the title Review step wording for 1.0 release Review step wording Jun 16, 2019
@mvz
Copy link
Contributor Author

mvz commented Jun 16, 2019

Delaying this to at least 1.1

@mvz mvz modified the milestones: 1.1.0, 1.2.0 Aug 21, 2020
@mvz mvz modified the milestones: 1.2.0, 2.0.0 Jun 20, 2021
@mvz mvz modified the milestones: 2.0.0, 2.1.0 Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
user experience
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
2 participants
@mvz @xtrasimplicity