Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pretty formatter does not report rules #1547

Open
aurelien-reeves opened this issue May 28, 2021 · 5 comments
Open

The pretty formatter does not report rules #1547

aurelien-reeves opened this issue May 28, 2021 · 5 comments
Labels
🏦 debt Tech debt 🐛 bug Defect / Bug ⌛ stale Will soon be closed by stalebot unless there is activity ✅ accepted The core team has agreed that it is a good idea to fix this

Comments

@aurelien-reeves
Copy link
Contributor

From a Slack conversation here: https://cucumberbdd.slack.com/archives/C7676D8GN/p1622078810002700

When running $ cucumber --format pretty on a file that uses the “Rule” keyword, with Cucumber 6, should I be seeing the Rules print out to the console along with the Features and Scenarios? I have my file formatted like this:

Feature: ...
  Rule: ...
    Scenario: ...
      Given
      When
      Then

But I am not seeing the Rules print out to the console.

Note: the pretty formatter is hard to maintain

Suggestion: having the pretty formatter rewritten into the monorepo to use shared testdata and have a consistent behavior in different languages.

@aurelien-reeves aurelien-reeves added 🐛 bug Defect / Bug ✅ accepted The core team has agreed that it is a good idea to fix this 🏦 debt Tech debt labels May 28, 2021
@aslakhellesoy
Copy link
Contributor

If we do this, it we should also consider how we support Markdown.

Markdown produces the same AST as Gherkin classic, so as long as the formatter uses the AST there would be no special considerations.

Another way to support Markdown is to pribt the source, but with additional Markup to represent results. That way the output would be valid Markdown with results, and without the need for JavaScript to render it.

@aurelien-reeves
Copy link
Contributor Author

I am confused here.
May the pretty formatter be used for something else than plain text primarily to stdout?

@aslakhellesoy
Copy link
Contributor

The output would be human readable, but if you chose to redirect it to a file, it could also be rendered by a markdown processor.

@aurelien-reeves
Copy link
Contributor Author

Ok, thanks for the clarification 🙂

@stale
Copy link

stale bot commented Apr 14, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two months if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt 🐛 bug Defect / Bug ⌛ stale Will soon be closed by stalebot unless there is activity ✅ accepted The core team has agreed that it is a good idea to fix this
Projects
None yet
Development

No branches or pull requests

2 participants