Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature keyword is marked as required but there is test data with features withoud keyword #136

Open
elchupanebrej opened this issue Jul 15, 2023 · 1 comment

Comments

@elchupanebrej
Copy link

👓 What did you see?

I use jsonschema to generate code for messages and found that it couldn't work with
https://github.com/cucumber/gherkin/blob/main/testdata/good/misc.feature.md.ast.ndjson

because Feature keyword is marked as required:

    "Feature": {
      "additionalProperties": false,
      "required": [
        "location",
        "tags",
        "language",
        "keyword",
        "name",
        "description",
        "children"
      ],

✅ What did you expect to see?

Make Feature keyword non-required or fix testdata

📦 Which tool/library version are you using?

Messages 22.0.0

📚 Any additional context?


This text was originally generated from a template, then edited by hand. You can modify the template here.

@mpkorstanje mpkorstanje transferred this issue from cucumber/messages Jul 15, 2023
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Jul 15, 2023

I'm moving this to the Gherkin repo. Looks like the Markdown parser doesn't set the feature keyword when the .feature.md file doesn't use a feature header and uses the document title instead. I would consider this a bug in the parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants