Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objective-c: Is not build in CI and does not follow the repository template #39

Open
Tracked by #2
mpkorstanje opened this issue Nov 8, 2022 · 0 comments
Open
Tracked by #2

Comments

@mpkorstanje
Copy link
Contributor

🤔 What's the problem you've observed?

Currently Objective-C is not build in CI and does not fully implement the acceptance test suite.

Compare:

.compared: .built $(TOKENS)
#.compared: .built $(TOKENS) $(ASTS) $(ERRORS)

Against:

acceptance: .built $(TOKENS) $(ASTS) $(PICKLES) $(ERRORS) $(SOURCES) ## Build acceptance test dir and compare results with reference

This is a problem because:

As of May 2016 Gherkin is implemented in 8 languages. This number is likely to increase to a dozen within a year or two. Very few programmers are intimate with all those languages. Therefore, in order to make it as easy as possible to refactor, fix bugs, add features and release packages it is essential that all implementations have a similar structure.

CONTRIBUTING.md - consistency between implementations

✨ Do you have a proposal for making it better?

Either

  • Remove objective-c from the list of supported implementations
  • Fix the build process

📚 Any additional context?

The objective-c project was already not build in CI while in the common repo. I would be surprised if it even works.

@mpkorstanje mpkorstanje mentioned this issue Nov 8, 2022
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant