Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French equivalent of Given is invariable #9

Open
ecattez opened this issue Sep 9, 2022 · 12 comments
Open

French equivalent of Given is invariable #9

ecattez opened this issue Sep 9, 2022 · 12 comments

Comments

@ecattez
Copy link

ecattez commented Sep 9, 2022

🤔 What's the problem you're trying to solve?

The equivalent of Given in French is invariable. It should be Etant donné or Etant donné que only.

✨ What's your proposed solution?

Remove all existing sentences, other than Etant donné and Etant donné que:

  • Etant donnée
  • Etant données
  • Etant donnés

⛏ Have you considered any alternatives or workarounds?

Let people write French like they want, but that would be direspectful for the language.


This text was originally generated from a template, then edited by hand. You can modify the template here.

@ecattez ecattez changed the title French French equivalent of Given is invariable Sep 9, 2022
@mpkorstanje mpkorstanje transferred this issue from cucumber/cucumber-jvm Sep 9, 2022
@mpkorstanje
Copy link
Contributor

Cucumber JVM generates the annotations based on Gherkin. So I'm moving this to the common repo.

The translations can be found in:

https://github.com/cucumber/common/blob/main/gherkin/gherkin-languages.json#L1308

@aslakhellesoy
Copy link
Contributor

aslakhellesoy commented Sep 10, 2022

@ecattez @fdelbrayelle how would you translate the following English step to French:

Given the following cars:
  | year | car                        |
  | 1936 | Bugatti Type 57SC Atlantic |
  | 1948 | Tucker Torpedo             |

I would write it like this:

Étant données les voitures suivantes:
  |  année | voiture                    |
  |   1936 | Bugatti Type 57SC Atlantic |
  |   1948 | Tucker Torpedo             |

I am not a native French speaker so I might have something to learn about grammar here...

@aslakhellesoy
Copy link
Contributor

/cc @boucardbruno and @jbpros who added this translation here: cucumber-attic/gherkin2@v2.5.1...v2.5.2

@ecattez
Copy link
Author

ecattez commented Sep 10, 2022

Hello @aslakhellesoy.

It would be Étant donné les voitures suivantes. It's a particular thing of French grammar called '' preposition ''. If it was after the car, it would be Les voitures suivantes étant données.

You could find more info here : https://www.larousse.fr/dictionnaires/francais/%C3%A9tant_donn%C3%A9/31312

@aslakhellesoy
Copy link
Contributor

Wow you learn something new every day. I’m all for removing the grammatically incorrect synonyms, but it would require a major release of Gherkin (and anything depending on it).

@ecattez
Copy link
Author

ecattez commented Sep 10, 2022

I agree. Maybe we could deprecate all wrong synonyms before removing them?

@aslakhellesoy
Copy link
Contributor

It’s deprecate :-). We don’t have a deprecation mechanism for keywords. Maybe we should make one…

@ecattez
Copy link
Author

ecattez commented Sep 11, 2022

If it does not happen often, such a mechanism is not necessary, IMO

@ciaranmcnulty
Copy link
Contributor

@stof

@jbpros
Copy link
Member

jbpros commented Sep 11, 2022

/cc @boucardbruno and @jbpros who added this translation here: cucumber-attic/gherkin2@v2.5.1...v2.5.2

Désolé! 🤓

I must say, now that I see it, I’m embarrassed I let that mistake go through!

@ecattez
Copy link
Author

ecattez commented Sep 11, 2022

It happens. I'm French native and I discovered that rule few days ago. So we were wrong writing scenarios in team 😅

@ciaranmcnulty
Copy link
Contributor

I think 'people may write the scenario like this' is more important than grammatical purity though?

@mpkorstanje mpkorstanje transferred this issue from cucumber/common Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants