Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit quotations from string parameter suggestions #140

Open
znevrly opened this issue Jan 5, 2023 · 1 comment
Open

Omit quotations from string parameter suggestions #140

znevrly opened this issue Jan 5, 2023 · 1 comment
Labels
good first issue Good for newcomers ⚡ enhancement Request for new functionality

Comments

@znevrly
Copy link

znevrly commented Jan 5, 2023

👓 What did you see?

When there is a step with Cucumber expression {string} then after selecting this suggestion:

  1. all text including double quotes is selected
  2. VS code is suggesting some values for parameter itself (I didn't find out what is mechanism e.g from currently opened file etc)

image

image

✅ What did you expect to see?

  1. only text inside double quotes is selected
  2. default value should be just empty string because there is very little chance to have valid suggestion for parameter

Surprisingly it works for regular expression e.g /^PATCH request to "(.*)" with body:$/
Also it's ok with Cucumber expression {int} because there is no need for double quotes.

📦 Which tool/library version are you using?

Cucumber plugin: v1.7.0, VS code: 1.74.2

🔬 How could we reproduce it?

Steps to reproduce the behavior:

Install Cucumber extension v1.7 onto latest VS Code
Have step definition with Cucumber expression {string}
Create any feature file
Use autocomplete suggestion for this step

@kieran-ryan
Copy link
Sponsor Member

kieran-ryan commented Dec 2, 2023

Hi @znevrly, the completions are built from your glue files (where your step definitions are defined) and gherkin steps from your feature files.

Looks like would be a nice developer experience enhancement - will update title to reflect and label accordingly. Thanks!

@kieran-ryan kieran-ryan changed the title UX issue of autocomplete suggestions with parameters Only text should be suggested for completions with string parameters Dec 30, 2023
@kieran-ryan kieran-ryan added the ⚡ enhancement Request for new functionality label Dec 30, 2023
@kieran-ryan kieran-ryan changed the title Only text should be suggested for completions with string parameters Suggest the text only for completions with string parameters Dec 30, 2023
@kieran-ryan kieran-ryan changed the title Suggest the text only for completions with string parameters Suggest the text only with completions for string parameters Dec 30, 2023
@kieran-ryan kieran-ryan changed the title Suggest the text only with completions for string parameters Omit quotations from string parameter suggestions Jan 2, 2024
@kieran-ryan kieran-ryan added the good first issue Good for newcomers label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ⚡ enhancement Request for new functionality
Projects
None yet
Development

No branches or pull requests

2 participants