{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":382379200,"defaultBranch":"master","name":"cue","ownerLogin":"cue-lang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2021-07-02T14:55:44.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/62243907?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716528948.0","currentOid":""},"activityList":{"items":[{"before":"4fe848db9106ac38e66ab551a3c56b2e52652202","after":"927c5037cebc0d89fae9397f033c4f197262dca1","ref":"refs/heads/master","pushedAt":"2024-05-24T05:35:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"internal/ci: fix 'hotfix' for GitHub Actions oneof\n\nhttps://cuelang.org/cl/1194548 upgrade this repo to use the latest\nversion of the GitHub Actions JSON Schema as its source of truth.\n\nThat same CL also included a 'hotfix' to deal with the fact that CUE\ndoes not today properly encode the concept of a oneof from JSON Schema.\nDiscussion on this point is taken up in https://cuelang.org/issue/3165.\n\nHowever the 'hotfix' incorrectly made steps a regular field as part of a\njob. Generally speaking, constraints in a schema should be optional or\nrequired. And in this case it is an optional field because reusable\nworkflows do not specify steps (and there is a constraint that where\nsteps are specified there must be at least one).\n\nFix that by making the hotfix specify the constraint via an optional\nfield.\n\nSigned-off-by: Paul Jolly \nChange-Id: I5925aa01e0df3ccf8a54b111314994bc94ddd0e7\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195124\nReviewed-by: Daniel Martí \nReviewed-by: Jonathan Matthews \nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine ","shortMessageHtmlLink":"internal/ci: fix 'hotfix' for GitHub Actions oneof"}},{"before":"c41955b39207044bde0d68933cc0cf9af239bb58","after":"4fe848db9106ac38e66ab551a3c56b2e52652202","ref":"refs/heads/master","pushedAt":"2024-05-23T15:38:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"internal/encoding/yaml: decode invalid YAML 1.1 octals as strings\n\nThat is, the input\n\n not_octal_yaml11: 0123456789\n\nused to give the error\n\n cannot decode \"0123456789\" as !!float: illegal integer number \"0123456789\"\n\ngiven that YAML would hint that the value was float rather than int\n(given that it is not made up of octal digits), and we would try to\ndecode as the CUE decimal literal 0123456789, which is invalid\nsince a decimal can only start with \"0\" when it is the zero number:\n\n decimal_lit = \"0\" | ( \"1\" … \"9\" ) { [ \"_\" ] decimal_digit } .\n\nMuch like other YAML decoders when they interpret this edge case,\nincluding go-yaml itself, we now decode the input value as a CUE string:\n\n not_octal_yaml11: \"0123456789\"\n\nNote that an alternative would be decoding as the valid CUE integer\n\n not_octal_yaml11: 123456789\n\nand, while this may be OK for some programs using YAML 1.2 only\nthat meant the value to be a decimal integer, some other programs\nmay be depending on the string semantics where the leading 0 is kept.\n\nFixes #2578.\n\nSigned-off-by: Daniel Martí \nChange-Id: If21bd469a2f75e07b76020451633627887868338\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195047\nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine \nReviewed-by: Roger Peppe ","shortMessageHtmlLink":"internal/encoding/yaml: decode invalid YAML 1.1 octals as strings"}},{"before":"9394167804a67bf7c1c9b5cd9c460422e81f59c9","after":"c41955b39207044bde0d68933cc0cf9af239bb58","ref":"refs/heads/master","pushedAt":"2024-05-23T15:38:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"internal/encoding/yaml: add test cases for YAML 1.1 and 1.2 octals\n\nYAML 1.1 has octal numbers with the \"0\" prefix,\nwhereas YAML 1.2 has octal numbers with the \"0o\" prefix.\nBoth are used in the wild, so we must be able to handle both.\n\nRight now, a non-octal number beginning with \"0\" results in an error,\nwhereas most YAML decoders, including go-yaml's Unmarshal,\nfall back to decoding the value as a string.\nWe will implement a fix like that in a follow-up commit;\nthis commit simply adds test cases to show the current behavior.\n\nAlso add cases where YAML 1.1 and 1.2 octal integer literals\nare prefixed with an explicit !!float tag, where the user definitely\ndoes not mean the input to be an octal integer.\nWe don't want any change in our handling of octal integers to change\nthese cases, even if one of the cases is broken per the added TODO.\n\nFor #2578.\n\nSigned-off-by: Daniel Martí \nChange-Id: I46f54f43d7f47c83ec907e421a37b049ad9d3137\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195046\nTryBot-Result: CUEcueckoo \nReviewed-by: Roger Peppe \nUnity-Result: CUE porcuepine ","shortMessageHtmlLink":"internal/encoding/yaml: add test cases for YAML 1.1 and 1.2 octals"}},{"before":"fca1bcc3e1ea57373ad8724854ebbd2de2ee0855","after":"9394167804a67bf7c1c9b5cd9c460422e81f59c9","ref":"refs/heads/master","pushedAt":"2024-05-23T09:08:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"cmd/cue: get the working directory once at init time\n\nThis way we don't have to get it separately in multiple places,\nparticularly each time that we print an error.\n\nSigned-off-by: Daniel Martí \nChange-Id: I305744a3984a832566a6c70a47dfd24152f3759e\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195084\nReviewed-by: Roger Peppe \nUnity-Result: CUE porcuepine \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"cmd/cue: get the working directory once at init time"}},{"before":"2adcaa6507722785996072a7d3db2082e7b469c4","after":"fca1bcc3e1ea57373ad8724854ebbd2de2ee0855","ref":"refs/heads/master","pushedAt":"2024-05-23T08:49:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"all: resolve unused value and yoda conditionals staticcheck warnings\n\nValues which are assigned to a variable but unused are either benign,\nwhich cause the code to be confusing to the reader,\nor actually lead to bugs, such as missed error checks in some tests.\n\nAlso, consistently place the constant on the right side in comparisons.\n\nSigned-off-by: Daniel Martí \nChange-Id: Icb5ef7c57fd26c6e2f82bf7309ebcbea1c5d0fbe\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195056\nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine \nReviewed-by: Roger Peppe ","shortMessageHtmlLink":"all: resolve unused value and yoda conditionals staticcheck warnings"}},{"before":"a6a7002b7bc688fd6d4f37b9273cd88a605085db","after":"2adcaa6507722785996072a7d3db2082e7b469c4","ref":"refs/heads/master","pushedAt":"2024-05-23T08:48:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"internal/encoding/yaml: add underlying error to \"cannot decode V as T\"\n\nThis can be useful context that would otherwise be lost.\nSome of these errors may be a bit repetitive, such as repeating\nthe input YAML string, but that's fine.\n\nSigned-off-by: Daniel Martí \nChange-Id: Ia95c25566288a4f1b7403a7b1fec1fe1e13ae92e\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195045\nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine \nReviewed-by: Roger Peppe ","shortMessageHtmlLink":"internal/encoding/yaml: add underlying error to \"cannot decode V as T\""}},{"before":"3ce48c0beadfc8b3d22285a197c9ebd53f4bd59a","after":"a6a7002b7bc688fd6d4f37b9273cd88a605085db","ref":"refs/heads/master","pushedAt":"2024-05-22T15:25:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"all: tidy up deprecation warnings a bit\n\nIn APIs like Runtime.Compile, point to non-deprecated alternatives,\nrather than pointing to methods which are themselves also deprecated.\n\nWhile here, tidy up other deprecated notes so that they use doc links.\n\nAlso note that Instance.LookupField had two deprecation notices;\nonly the second seems to have been up to date.\n\nFixes #1735.\n\nSigned-off-by: Daniel Martí \nChange-Id: Ie8d8ba3e76855f36d3746a1e65c9d8af17737dbc\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195013\nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine \nReviewed-by: Paul Jolly ","shortMessageHtmlLink":"all: tidy up deprecation warnings a bit"}},{"before":"a90aec5c611bda3d73dfe484d4794e07499ff2ae","after":"3ce48c0beadfc8b3d22285a197c9ebd53f4bd59a","ref":"refs/heads/master","pushedAt":"2024-05-22T08:37:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"all: resolve a handful of linter warnings\n\ncue/parser's use of astinternal is just in the tests,\nso there's no need to import it in the non-test code.\nThere's also no reason to define a func variable.\n\nRemove a few unused fields and one type.\n\nIn internal/core/export's test, use an underscore assignment\nso that the debugValue constant doesn't trigger \"unused\" warnings.\n\nSigned-off-by: Daniel Martí \nChange-Id: Id117bb2e5a8c6fd6c7d01f7f7782719663a6fddb\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195020\nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine \nReviewed-by: Roger Peppe ","shortMessageHtmlLink":"all: resolve a handful of linter warnings"}},{"before":"74519675c9dfe27513c67b4f1605f2fbb2852b9d","after":"a90aec5c611bda3d73dfe484d4794e07499ff2ae","ref":"refs/heads/master","pushedAt":"2024-05-21T13:32:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"cue: add a regression test for a closedness bug fixed in evalv3\n\nIn the added test case, the struct with the \"name\" field is closed\nas it is referenced via the parent definition,\nso trying to insert new fields via unification should fail.\n\nThe new evaluator fixes this case, as can be seen in the eval diff.\nIt seems the old evaluator wasn't tracking closedness properly here.\n\nCloses #1830.\n\nSigned-off-by: Daniel Martí \nChange-Id: I9f96baa377f2f5cd5ab66491f1e3ca112cd33ab9\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195009\nReviewed-by: Paul Jolly \nUnity-Result: CUE porcuepine \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"cue: add a regression test for a closedness bug fixed in evalv3"}},{"before":"4900cfc6511464d706c1f5f520c1a87b7dc6dca7","after":"74519675c9dfe27513c67b4f1605f2fbb2852b9d","ref":"refs/heads/master","pushedAt":"2024-05-21T13:30:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"cuepls: minimal fix to make compilation work vs Go tip\n\nThe internal/golangorgx/... packages contain vendored (and modified)\nversions of various (internal) packages from golang.org/x/tools,\ngolang.org/x/tools/gopls and golang.org/x/telemetry. As such, it's not\nuncommon for things to break, because we are relying on internals.\n\nGo tip has made a change as part of https://golang.org/issue/67182 that\ncauses us to break with respect to the originally vendored code. We make\na surgical update to the golang.org/x/telemetry to fix that break,\nrather than trying to revendor all/part of the original package set\n(which at this stage would be a lot of work).\n\nVerified by running go test ./... with:\n\n go version devel go1.23-1cb13ac7f6 Tue May 21 11:57:40 2024 +0000 linux/arm64\n\nSigned-off-by: Paul Jolly \nChange-Id: I7554632f3b6d38fb73484602770ed28e681d4341\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195010\nReviewed-by: Daniel Martí \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"cuepls: minimal fix to make compilation work vs Go tip"}},{"before":"7d49080bb7ab8518a43bc9fe743e302f14c28712","after":"4900cfc6511464d706c1f5f520c1a87b7dc6dca7","ref":"refs/heads/master","pushedAt":"2024-05-21T12:06:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"cue: add a regression test for a disjunction bug fixed in evalv3\n\nAs can be seen in the diff, the old evaluator resulted in the fields:\n\n h: a: v: *\"a\" | \"b\" | \"c\"\n h: b: v: *\"a\" | \"b\" | \"c\"\n h: c: v: *\"a\" | *\"b\" | *\"c\"\n\nWhich, when exporting, would understandably result in an error:\n\n h.c.v: incomplete value \"a\" | \"b\" | \"c\"\n\nThe new evaluator correctly keeps \"a\" as the only default in all fields:\n\n h: a: v: *\"a\" | \"b\" | \"c\"\n h: b: v: *\"a\" | \"b\" | \"c\"\n h: c: v: *\"a\" | \"b\" | \"c\"\n\nCloses #770.\n\nSigned-off-by: Daniel Martí \nChange-Id: Id3e5e9c522307900331dc0fa29b936f773750497\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1195003\nReviewed-by: Paul Jolly \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"cue: add a regression test for a disjunction bug fixed in evalv3"}},{"before":"7d93bcc9fad6886aeac650bba7ac58756c1cd6d5","after":"7d49080bb7ab8518a43bc9fe743e302f14c28712","ref":"refs/heads/master","pushedAt":"2024-05-20T14:04:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"cue/load: replace readimports with cueimports.Read\n\nPretty much the same code inherited from Go.\nThe way cue/load used it already matched the cueimports.Read API.\n\nWhile here, fileProcessor.add only needs to use cue/parser to read\na CUE file's package clause and imported package paths,\nso there is no need to parse comments at all.\n\nSigned-off-by: Daniel Martí \nChange-Id: I67c5349dd691b282a8c4c1fbd3dd5daaf7f10163\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194965\nUnity-Result: CUE porcuepine \nTryBot-Result: CUEcueckoo \nReviewed-by: Roger Peppe ","shortMessageHtmlLink":"cue/load: replace readimports with cueimports.Read"}},{"before":"c0d619382a6dc74c502c5f19e6ef15280339b0a8","after":"7d93bcc9fad6886aeac650bba7ac58756c1cd6d5","ref":"refs/heads/master","pushedAt":"2024-05-20T13:41:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"internal/mod/modimports: use cue/parser.ImportsOnly\n\nInvalid syntax after import declarations should be handled consistently\nno matter whether a file started with a package clause or not.\nIf for any reason cueimports.Read thinks there is invalid syntax\nand reads the entire source, such as when a package clause is missing,\nstop cue/parser from parsing the entire file as well.\n\nNot only is parsing the entire file in that case wasteful,\nbut it also leads to errors which aren't particularly useful\nwhen all we care about here is listing imported packages.\n\nWhile here, remove the use of ParseComments; none of the modimports\nusers need to parse comments at the top of the file.\nThis is a remnant from Go, where comments at the top of the file\nare important as they may contain build tag directives.\n\nSigned-off-by: Daniel Martí \nChange-Id: I35eeade6481b74da7f04240f9ef85da338491f7e\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194961\nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine \nReviewed-by: Roger Peppe ","shortMessageHtmlLink":"internal/mod/modimports: use cue/parser.ImportsOnly"}},{"before":"38185284ce8c4f520bb51db60dc2ceaeba90f434","after":"c0d619382a6dc74c502c5f19e6ef15280339b0a8","ref":"refs/heads/master","pushedAt":"2024-05-20T13:41:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"internal/mod/modimports: add more syntax edge cases to testdata\n\nI was surprised to see that modimports used cueimports.Read\nto only consume enough tokens to read a CUE file's import declarations.\nThis seems to have been inherited from Go, where there is this API:\n\n package imports\n\n func ReadImports(f io.Reader, reportSyntaxError bool, imports *[]string) ([]byte, error)\n\nThe reason ends up being the same for both Go and CUE, as CUE inherited\nmultiple Go API decisions from Go: both go/parser and cue/parser\nwill consume an entire input io.Reader, so when there are any large\nCUE files in a module, we would read the entire file into memory\nwhen in practice the imports are likely a tiny fraction of the bytes.\n\nAdd a comment explaining that, to prevent others from being surprised\njust like I was, and add a TODO about cue/parser being better.\n\nAdd plenty more testdata txtar cases for edge cases.\nNote that a few don't behave the way I might expect, so add TODOs.\n\nSigned-off-by: Daniel Martí \nChange-Id: I4a7890e5a52d2a71325676116c036095d330c4e4\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194954\nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine \nReviewed-by: Roger Peppe ","shortMessageHtmlLink":"internal/mod/modimports: add more syntax edge cases to testdata"}},{"before":"97bf1a6e6cd9ddc549304b36d41292eb885ce73b","after":"38185284ce8c4f520bb51db60dc2ceaeba90f434","ref":"refs/heads/master","pushedAt":"2024-05-20T09:46:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"all: remove various cue.Value.Lookup usages\n\nReplace various usages of the deprecated cue.Value.Lookup with\ncue.Value.LookupPath.\n\nAlso, fix some typos and reorganize some imports.\n\nUpdates #2480.\n\nSigned-off-by: Noam Dolovich \nChange-Id: I8faff629c07601dcb51fda527d8f10b80265bd92\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194951\nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine \nReviewed-by: Daniel Martí ","shortMessageHtmlLink":"all: remove various cue.Value.Lookup usages"}},{"before":"51cd5ca9c8b6989f92f129c88deba99f9104b0f7","after":"97bf1a6e6cd9ddc549304b36d41292eb885ce73b","ref":"refs/heads/master","pushedAt":"2024-05-18T15:53:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"internal/mod/modimports: avoid extra fs.Stat calls in AllModuleFiles\n\nAs reported by a user on a large repository with many hundreds\nof directories, CUE_EXPERIMENT=modules now being the default\ncaused a sudden increase in the number of file operations being done\nby cmd/cue when loading packages, causing a slow-down.\n\nWe can easily reproduce the issue via strace in our CUE repository,\nusing `cue fmt ./internal/ci` as an example to load one CUE package.\nWhere we used to only stat or open 8 cue.mod files, we now do 360:\n\n $ CUE_EXPERIMENT=modules=0 strace -f -t -e trace=file cue fmt ./internal/ci |& grep 'cue\\.mod\"' | wc -l\n 8\n $ strace -f -t -e trace=file cue fmt ./internal/ci |& grep 'cue\\.mod\"' | wc -l\n 360\n\nThe culprit turned out to be AllModuleFiles; the way it needs to skip\nwalking nested CUE modules did not fit well with the fs.WalkDir API.\nUsing fs.ReadDir and recursive func calls instead works better:\n\n $ strace -f -t -e trace=file cue fmt ./internal/ci |& grep 'cue\\.mod\"' | wc -l\n 8\n\nUpdates #3155.\n\nSigned-off-by: Daniel Martí \nChange-Id: I32dc0c39ea795f795077feff88475d38cb324433\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194921\nReviewed-by: Paul Jolly \nUnity-Result: CUE porcuepine \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"internal/mod/modimports: avoid extra fs.Stat calls in AllModuleFiles"}},{"before":"27689d278fc0049b9882fe792f4bba09d73f385c","after":"51cd5ca9c8b6989f92f129c88deba99f9104b0f7","ref":"refs/heads/master","pushedAt":"2024-05-17T14:02:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"pkg: remove usages of cue.Runtime in tests\n\nThis replaces various usages of cue.Runtime in tests with the equivalent\n*cue.Context methods.\n\n`cuecontext.New` can't be used directly, as this causes an import cycle.\nA `newContext` method already existed for creating a cue.Context, and\nis extracted to a shared internal func for reuse across pkg/...\n\nAlso, some typos are fixed.\n\nUpdates #2480.\n\nSigned-off-by: Noam Dolovich \nChange-Id: I9bcf3011096a17c3a7f81e80c57414a9b9d9b7b2\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194868\nUnity-Result: CUE porcuepine \nReviewed-by: Daniel Martí \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"pkg: remove usages of cue.Runtime in tests"}},{"before":"05453ff5230f212e41da5969ea7196f1a54d16b1","after":"27689d278fc0049b9882fe792f4bba09d73f385c","ref":"refs/heads/master","pushedAt":"2024-05-17T11:15:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"internal/ci: update goreleaser version for v0.9.0\n\nTo pick up a fix for a regression where release.draft was being ignored:\n\n https://github.com/goreleaser/goreleaser/issues/4862\n\nSigned-off-by: Daniel Martí \nChange-Id: I05732df79aa9fb6ae6b42f8ecfb88f033b9d5bdf\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194874\nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine \nReviewed-by: Paul Jolly ","shortMessageHtmlLink":"internal/ci: update goreleaser version for v0.9.0"}},{"before":"c3dc2f25771d476ff604a775c3aa91f2648784aa","after":"05453ff5230f212e41da5969ea7196f1a54d16b1","ref":"refs/heads/master","pushedAt":"2024-05-17T09:11:10.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"internal/registrytest: satisfy staticcheck and gopls\n\nauthnHandler has been unused since https://cuelang.org/cl/1191618,\nand the auth logic now lives in the serveDirectAuth method.\nPerhaps this func was left behind as part of a refactor.\n\nRemove a few other unused parameters and declarations,\nand actually check an error in the test code.\n\nSigned-off-by: Daniel Martí \nChange-Id: I9e445f71a94cebe76356fedbd9126cdcd0657f52\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194857\nTryBot-Result: CUEcueckoo \nReviewed-by: Paul Jolly \nUnity-Result: CUE porcuepine ","shortMessageHtmlLink":"internal/registrytest: satisfy staticcheck and gopls"}},{"before":"11cbcd3610c42740c60e97022e2392fcbdb81f01","after":"c3dc2f25771d476ff604a775c3aa91f2648784aa","ref":"refs/heads/master","pushedAt":"2024-05-17T08:59:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"internal/filetypes: remove unused test.cue file\n\nIt was added in 2020 but it is not consumed by any test anymore,\nnor it seems to have been modified since.\nWe already have plenty of tests as part of `go test`.\n\nSigned-off-by: Daniel Martí \nChange-Id: Ia67ecb7012c8cde5c01e64b35a48690bae72d8cc\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194861\nReviewed-by: Paul Jolly \nUnity-Result: CUE porcuepine \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"internal/filetypes: remove unused test.cue file"}},{"before":"078020b3a891545e3a5f02dcf43c99f6360f6b56","after":"11cbcd3610c42740c60e97022e2392fcbdb81f01","ref":"refs/heads/master","pushedAt":"2024-05-17T08:58:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"cmd/cue: ensure that fmt works outside a module with files too\n\nhttps://cuelang.org/cl/1194851 fixed this recent regression\nand added a test case with stdin outside of a CUE module,\nbut it didn't add a similar test case with a file argument.\n\nSigned-off-by: Daniel Martí \nChange-Id: I06a17b1edf8651210a0123b0f260f42d16031a93\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194853\nUnity-Result: CUE porcuepine \nTryBot-Result: CUEcueckoo \nReviewed-by: Paul Jolly ","shortMessageHtmlLink":"cmd/cue: ensure that fmt works outside a module with files too"}},{"before":"27a0190003a1da7cc6462e59d582100b0cd17e27","after":"078020b3a891545e3a5f02dcf43c99f6360f6b56","ref":"refs/heads/master","pushedAt":"2024-05-17T08:57:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"encoding/gocode/gocodec: remove cue.Runtime usages\n\nThis removes most usages of cue.Runtime in gocodec tests, except for a\nsmoke test that ensures the deprecated cue.Runtime still works with\nthe API.\n\nAlso, the package doc is fixed to reference the correct package name.\n\nUpdates #2480.\n\nSigned-off-by: Noam Dolovich \nChange-Id: I464e0d730fbdfaf5afc8bebd547b7f1590f2dd93\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194862\nUnity-Result: CUE porcuepine \nReviewed-by: Daniel Martí \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"encoding/gocode/gocodec: remove cue.Runtime usages"}},{"before":"3588e1a75158e055180de4e0b98f00a09e59196d","after":"27a0190003a1da7cc6462e59d582100b0cd17e27","ref":"refs/heads/master","pushedAt":"2024-05-16T21:06:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"encoding/toml: add support for inline tables\n\nDecoding a field is moved to a method, as now it is used for both\ntop-level key-values as well as key-values inside an inline table.\nWe will soon use this method for tables with headers too.\n\nWhile here, add more edge cases for duplicate keys as well as\ntest cases where the keys are different but in subtle ways.\n\nAnd also ensure that go-toml's Unmarshal errors on all the cases\nwhere our decoder errors, primarily to ensure that we are identical\nin terms of failing on duplicate keys.\nThis test validation with go-toml might need to be tweaked\nif or when our decoder ever starts giving any CUE-specific errors.\n\nSigned-off-by: Daniel Martí \nChange-Id: Idfb92615c2bbdfd2cdc7fe299990438bdf4eb009\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194758\nReviewed-by: Roger Peppe \nUnity-Result: CUE porcuepine \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"encoding/toml: add support for inline tables"}},{"before":"96f16f0c5164d3692ee1b91604658ca140361995","after":"3588e1a75158e055180de4e0b98f00a09e59196d","ref":"refs/heads/master","pushedAt":"2024-05-16T20:02:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"cue: add another test for a disjunction bug fixed in evalv3\n\nThe old evaluator incorrectly errors, but the new one doesn't.\n\nWhile here, namespace the fields of the recently added issue1417.cue,\nwhich I forgot to do, and makes the file consistent with the others.\n\nCloses #3149.\n\nSigned-off-by: Daniel Martí \nChange-Id: I1cdf4af8aa52c0ca8dd1ff82c42b0b5c25bb4e20\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194855\nReviewed-by: Marcel van Lohuizen \nUnity-Result: CUE porcuepine \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"cue: add another test for a disjunction bug fixed in evalv3"}},{"before":"fa64c6280f0193190fd474cb04a2ad8788353a72","after":"96f16f0c5164d3692ee1b91604658ca140361995","ref":"refs/heads/master","pushedAt":"2024-05-16T17:04:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"all: various very small cleanups from gopls and staticcheck\n\nI had been accumulating tiny tweaks and cleanups that were too small\nto require a commit or review of their own.\n\n* doTasks has had an unused parameter for a long time.\n* publishRegistryResolverShim has an unused field.\n* writeIndex did not actually check an error from os.WriteFile.\n* extractFeatures can prepare the right slice capacities ahead of time.\n* A few places can avoid the type parameter in generic func calls;\n note that type inference got much better with Go 1.21.\n* zeroReader.Read can make use of the new clear builtin in Go 1.21\n\nSigned-off-by: Daniel Martí \nChange-Id: I4206073007191c28782acebe926c00ce3c3498db\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194842\nUnity-Result: CUE porcuepine \nReviewed-by: Noam Dolovich \nTryBot-Result: CUEcueckoo \nReviewed-by: Roger Peppe ","shortMessageHtmlLink":"all: various very small cleanups from gopls and staticcheck"}},{"before":"1ad8c52099795475641ce334daac2cc3e61e984d","after":"fa64c6280f0193190fd474cb04a2ad8788353a72","ref":"refs/heads/master","pushedAt":"2024-05-16T16:56:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"cue/load: treat all absDirFromImportPath errors as PackageErrors\n\nWhen `cue fmt` is formatting files, it explicitly checks for,\nand ignores, `load.PackageError`. If we fail to load a package\nin any way, we should ignore such a failure, so make\nall errors returned by `absDirFromImportPath` (the primary\nsource of such errors), into a `PackageError`.\n\nSigned-off-by: Roger Peppe \nChange-Id: I3dafe2c7432342ebb96119b29d5b8796979a18d2\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194851\nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine \nReviewed-by: Daniel Martí ","shortMessageHtmlLink":"cue/load: treat all absDirFromImportPath errors as PackageErrors"}},{"before":"4a27795456a14d58f3dce5a8e1fa1a59ec8b73e5","after":"1ad8c52099795475641ce334daac2cc3e61e984d","ref":"refs/heads/master","pushedAt":"2024-05-16T12:19:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"internal/cueexperiment: flip modules experiment flag default\n\nThis change enables the modules experiment by default.\nThis will cause CUE code to fail if there is no language\nversion in the module.cue file, amongst other things.\n\nThe experiment can be disabled by setting\n\n CUE_EXPERIMENT=modules=0\n\nMany of the unit tests need to be changed in order to\nadd the now-mandatory language.version field.\n\nSome error messages have now changed.\n\nSome logic in the `cue fmt` command that relies on seeing\na `load.PackageError` required the respective code inside\n`cue/load` to produce that error, which also changes some\nerror messages.\n\nThe `cue mod fix` command is now available to make it\nit more straightforward to migrate.\n\nThe module path in encoding/gocode/testdata/cue.mod/module.cue\nhas been changed to match the modules-enabled default,\notherwise the generation code fails with an error about a mismatched\nmodule path.\n\nFixes #3127.\n\nSigned-off-by: Roger Peppe \nChange-Id: I7c384c785eac6203966460703283ecfa2d9f0447\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194664\nReviewed-by: Daniel Martí \nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine ","shortMessageHtmlLink":"internal/cueexperiment: flip modules experiment flag default"}},{"before":"ac35a4064328e235d002ae80d70a05931daffae9","after":"4a27795456a14d58f3dce5a8e1fa1a59ec8b73e5","ref":"refs/heads/master","pushedAt":"2024-05-16T11:45:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"cue/load: set the absolute file name when setting source\n\nThis means that when the file is decoded, the `internal/encoding.NewDecoder`\nlogic can find it, even though `internal/encoding.Config` doesn't\ncontain a directory field to interpret relative file paths.\n\nThis fixes a test failure that happens when the modules experiment\nflag is enabled by default.\n\nSigned-off-by: Roger Peppe \nChange-Id: Ia606ce2dc0fca816f3986c24fda96041862b0297\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194830\nTryBot-Result: CUEcueckoo \nUnity-Result: CUE porcuepine \nReviewed-by: Daniel Martí ","shortMessageHtmlLink":"cue/load: set the absolute file name when setting source"}},{"before":"f513a178c6244b8ea4f3a277f625d40e5b718eea","after":"ac35a4064328e235d002ae80d70a05931daffae9","ref":"refs/heads/master","pushedAt":"2024-05-16T11:39:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"cue/load: do not scan imports of non-CUE files\n\nThe recent fix to do better with imports in command-line-specified files\n(https://cuelang.org/cl/1194765) changed cue/load to scan imports before\nloading files. It scans imports in all files including non-CUE files.\nThis turns out to be a problem because the code to get the CUE syntax in\nturn invokes the internal/encoding.Decoder logic which requires a fully\npopulated encoding.Config struct in order to do its job properly.\nSpecifically, the encoding.Config created by cue/load does not have the\nprotobuf import path required when decoding protobuf files, so this was\nfailing.\n\nWork around this by scanning imports of CUE files only, mirroring the\nsame logic in cue/load.matchFile.\n\nIn the future, we will probably have to rework this, as it's entirely\npossible that non-CUE specified on the command line might end up\nproducing a CUE representation that imports external CUE packages, but\nfor now this should be sufficient.\n\nSigned-off-by: Roger Peppe \nChange-Id: I703b7c1f95be253070792d7744589474ce88ad7a\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194827\nReviewed-by: Daniel Martí \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"cue/load: do not scan imports of non-CUE files"}},{"before":"0b70e5b47b46d74e7b8a20ce59af3ad313326533","after":"f513a178c6244b8ea4f3a277f625d40e5b718eea","ref":"refs/heads/master","pushedAt":"2024-05-16T11:39:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"cueckoo","name":"cueckoo","path":"/cueckoo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/62251246?s=80&v=4"},"commit":{"message":"cue/load: add major version suffix to module path in testdata\n\nWe are about to enable the modules experiment by default,\nand its new module.cue schema requires a major version suffix in module paths.\n\nSigned-off-by: Roger Peppe \nChange-Id: Ie1850a6acf2a7817fb7ec572c58850f23968d100\nReviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194790\nReviewed-by: Daniel Martí \nTryBot-Result: CUEcueckoo ","shortMessageHtmlLink":"cue/load: add major version suffix to module path in testdata"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUrCsqgA","startCursor":null,"endCursor":null}},"title":"Activity · cue-lang/cue"}