Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve UI unit tests performance issues and add tests run on push hook using husky #207

Closed
Aviv-Galmidi opened this issue Mar 2, 2021 · 1 comment
Assignees

Comments

@Aviv-Galmidi
Copy link
Collaborator

We currently run the client tests using Jest. Jest has a known performence issue, see here: jestjs/jest#7963

We want to add a pre-push hook using husky to run our UI unit tests and abort the push on failed tests, but as the tests currently take over 7 seconds to start up it might slow-down the process for each push and end up not cost-effective (vs the current test run on PR using github)

If we find an alternative to Jest or somehow we manage to resolve the performance issue we can attempt to add the tests run to the pre-push hook

@Aviv-Galmidi Aviv-Galmidi self-assigned this Mar 2, 2021
@Aviv-Galmidi
Copy link
Collaborator Author

After further investigation, I could not find a significant improvement with mocha over jest. For the time being we'll leave it as is (Jest + Tests run on github actions)

If anything changes in the future we may visit this subject again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant