Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled promise rejection #122

Open
bnb opened this issue Jul 22, 2019 · 3 comments
Open

Unhandled promise rejection #122

bnb opened this issue Jul 22, 2019 · 3 comments

Comments

@bnb
Copy link
Member

bnb commented Jul 22, 2019

I've gotten this a couple times recently. If anyone wants to tackle, feel free ❤️

$ good-first-issue

? Choose a project: debugger.html
(node:89426) UnhandledPromiseRejectionWarning: HttpError: Validation Failed
    at /Users/cyren/GitHub/good-first-issue/node_modules/@octokit/request/dist-node/index.js:66:23
    at processTicksAndRejections (internal/process/task_queues.js:89:5)
    at async search (/Users/cyren/GitHub/good-first-issue/lib/search.js:18:20)
    at async Command.<anonymous> (/Users/cyren/GitHub/good-first-issue/bin/good-first-issue.js:45:20)
(node:89426) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a
 catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:89426) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
@DanielRuf
Copy link
Contributor

Needs some try / catch block. I'll check that.

@DanielRuf
Copy link
Contributor

Needs some try / catch block. I'll check that.

This is not the case anymore as you already wrap the whole in a try / catch an return the error object. I think this can be closed.

@DanielRuf
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants