Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors better #78

Open
bnb opened this issue Dec 2, 2018 · 1 comment
Open

Handle errors better #78

bnb opened this issue Dec 2, 2018 · 1 comment

Comments

@bnb
Copy link
Member

bnb commented Dec 2, 2018

My internet is pretty flaky right now and disconnected while I was trying out a PR. Connection was reset, and a pretty nasty error was output to the console:

image
@hemal7735 hemal7735 mentioned this issue Dec 3, 2018
Open
@boneskull
Copy link
Contributor

The solution in #80 is along the lines of what should be happening. If good-first-issue knows that it's possible a connection could fail, it should present something useful to the user instead of a big stack trace. "Check your network connection..."

boneskull added a commit to boneskull/good-first-issue that referenced this issue Nov 13, 2019
@boneskull
feat: handle ENOTFOUND and ask users to report all other errors; closes
595bf69 
cutenode#78

This PR will ask users to report unhandled rejections or uncaught exceptions to the project issue tracker.

- added a test to check this is working
- added dev dep [execa](https://npm.im/execa) for said test
- added [buggin](https://npm.im/buggin) unexpected error output
boneskull added a commit to boneskull/good-first-issue that referenced this issue Dec 18, 2019
@boneskull
feat: handle ENOTFOUND and ask users to report all other errors; closes
8412038 
cutenode#78

This PR will ask users to report unhandled rejections or uncaught exceptions to the project issue tracker.

- added a test to check this is working
- added dev dep [execa](https://npm.im/execa) for said test
- added [buggin](https://npm.im/buggin) unexpected error output
@boneskull boneskull mentioned this issue Dec 18, 2019
Merged
boneskull added a commit to boneskull/good-first-issue that referenced this issue Dec 18, 2019
@boneskull
feat: handle ENOTFOUND and ask users to report all other errors; closes
fe02cec 
cutenode#78

This PR will ask users to report unhandled rejections or uncaught exceptions to the project issue tracker.

- added a test to check this is working
- added dev dep [execa](https://npm.im/execa) for said test
- added [buggin](https://npm.im/buggin) unexpected error output
boneskull added a commit to boneskull/good-first-issue that referenced this issue Dec 18, 2019
@boneskull
feat: handle ENOTFOUND and ask users to report all other errors; closes
2316990 
cutenode#78

This PR will ask users to report unhandled rejections or uncaught exceptions to the project issue tracker.

- added a test to check this is working
- added dev dep [execa](https://npm.im/execa) for said test
- added [buggin](https://npm.im/buggin) unexpected error output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnb @boneskull