Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable coverage tracking for src/Command/* #469

Open
cweagans opened this issue Feb 12, 2023 · 1 comment
Open

Re-enable coverage tracking for src/Command/* #469

cweagans opened this issue Feb 12, 2023 · 1 comment
Labels
bug Inconsistencies or issues which will cause a problem for users or implementors.

Comments

@cweagans
Copy link
Owner

cweagans commented Feb 12, 2023

In the tests, Composer commands are run in the same process as the tests to allow for easy debugging and coverage reporting. That functionality is implemented here: https://github.com/cweagans/composer-patches/blob/main/tests/_support/Helper/Composer.php

However, it does not work at all for the custom commands that are included in this plugin. There is a test that covers composer patches-relock and composer patches-repatch (https://github.com/cweagans/composer-patches/blob/main/tests/acceptance/CommandsCept.php), but if I change the ->runShellCommand() lines to their corresponding ->runComposerCommand() calls, I get all kinds of very strange errors.

I'm confident that those two commands are well tested and testing patches-doctor thoroughly isn't going to be a very straightforward thing. I'm not interested in holding up the 2.0.0 release on fixing that particular issue, but I also don't want to artificially deflate the amount of test coverage that this plugin has. Therefore, I've ignored the entire src/Command directory for coverage tracking. DoctorCommand isn't well tested right now, but I'll accept that.

@cweagans cweagans added the bug Inconsistencies or issues which will cause a problem for users or implementors. label Feb 12, 2023
cweagans added a commit that referenced this issue Feb 12, 2023
@stale
Copy link

stale bot commented Mar 14, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 14, 2023
@stale stale bot closed this as completed Mar 21, 2023
@cweagans cweagans reopened this Jun 30, 2023
@github-actions github-actions bot removed the stale label Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

1 participant