Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONCEPT] Nullable flags #12

Open
antonkomarev opened this issue Jan 6, 2017 · 0 comments
Open

[CONCEPT] Nullable flags #12

antonkomarev opened this issue Jan 6, 2017 · 0 comments

Comments

@antonkomarev
Copy link
Member

antonkomarev commented Jan 6, 2017

It's just a concept. Not yet decided if it will be included in future.

Add nullable flags state which will means that none of the actions were performed.

To proof concept we'll look at Classic\Accept flag there could be 3 states:

  • is_accepted = null - Not accepted and not rejected yet.
  • is_accepted = true - Entity was accepted.
  • is_accepted = false - Entity was rejected.

Scopes

NULL

  • withNotYetAccepted will get true + null entities.
  • withoutNotYetAccepted will omit only null entities.
  • onlyNotYetAccepted will get only null entities.

FALSE

  • withRejected will get true + false entities.
  • withoutRejected will omit only false entities.
  • onlyRejected will get only false entities.

NULL + FALSE

  • Some method to get null + false + true entities. Right now withRejected method is removing global scope.

The main issue here that all FALSE scopes removes global scope, and entities with NULL flag will be displayed then.

// :TODO: Write test case and try to implement nullable flag

Or find another solution, like extra database table to display what entities was not accepted or rejected yet.

@antonkomarev antonkomarev changed the title Nullable flags [CONCEPT] Nullable flags Jan 7, 2017
@antonkomarev antonkomarev mentioned this issue Jan 11, 2017
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant