Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set future date for timestamp flags #22

Open
antonkomarev opened this issue Jan 14, 2017 · 1 comment
Open

Set future date for timestamp flags #22

antonkomarev opened this issue Jan 14, 2017 · 1 comment

Comments

@antonkomarev
Copy link
Member

This could be useful for example when you want an article to be automatically shown in future date.

Right now if future published_at will be setted - this record will be published immediately. Global scopes and helpers should check not for the null value, but for the exact date is past.

This use case will be useful for all timestamp flags. For example expired_at flag will be useful for subscriptions and so on.

@antonkomarev
Copy link
Member Author

The main issues are:

More complex queries

Checks for dates instead of NULL values.

Before:

$builder->whereNotNull('accepted_at');

After:

return $builder->where('accepted_at', '<=', Carbon::now());

Not all applications or models need such functionality

This could be solved by adding additional methods to check if this functionality is required. Each flag should has +1 method.

Scopes naming

For the flag AcceptedAt there are methods like: withRejected, onlyRejected. Should this methods include record which will be accepted in future? Technically it isn't accepted yet because of future timestamp. But logically it's not rejected already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant