From c34ccaf44ca3bb46eed3b8b47a75cdd37487db6f Mon Sep 17 00:00:00 2001 From: Toru Kobayashi Date: Mon, 25 May 2020 11:11:24 +0900 Subject: [PATCH] fix: review newly added rules in typescript-eslint BREAKING CHANGE: enable new rules in typescript-eslint/recommended --- lib/typescript.js | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/lib/typescript.js b/lib/typescript.js index 7bab1318..bd5331a5 100644 --- a/lib/typescript.js +++ b/lib/typescript.js @@ -1,10 +1,7 @@ module.exports = { parser: "@typescript-eslint/parser", plugins: ["@typescript-eslint"], - extends: [ - "plugin:@typescript-eslint/eslint-recommended", - "plugin:@typescript-eslint/recommended" - ], + extends: ["plugin:@typescript-eslint/recommended"], // It's 5〜10x slower with the project setting. // So We disable it until the issue has been fixed /* @@ -17,15 +14,12 @@ module.exports = { "no-useless-constructor": "off", "@typescript-eslint/no-useless-constructor": "warn", - "@typescript-eslint/type-annotation-spacing": "warn", "@typescript-eslint/unified-signatures": "warn", "@typescript-eslint/indent": ["warn", 2, { SwitchCase: 1 }], - "@typescript-eslint/ban-ts-ignore": "off", - "@typescript-eslint/camelcase": "off", - "@typescript-eslint/explicit-function-return-type": "off", + "@typescript-eslint/ban-ts-comment": "off", "@typescript-eslint/explicit-member-accessibility": "off", - "@typescript-eslint/interface-name-prefix": "off", + "@typescript-eslint/explicit-module-boundary-types": "off", "@typescript-eslint/no-explicit-any": "off", "@typescript-eslint/no-empty-interface": "off", "@typescript-eslint/no-inferrable-types": "off", @@ -34,7 +28,6 @@ module.exports = { "@typescript-eslint/no-object-literal-type-assertion": "off", "@typescript-eslint/no-triple-slash-reference": "off", "@typescript-eslint/no-unused-vars": "off", - "@typescript-eslint/no-use-before-define": "off", "@typescript-eslint/no-var-requires": "off", "@typescript-eslint/prefer-interface": "off", "@typescript-eslint/prefer-namespace-keyword": "off"