Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint v7 #272

Merged
merged 10 commits into from Jun 19, 2020
Merged

Support ESLint v7 #272

merged 10 commits into from Jun 19, 2020

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented May 12, 2020

ESLint v7 has been released so we'd like to support ESLint v7.
https://eslint.org/blog/2020/05/eslint-v7.0.0-released

THIS PR IS A BREAKING CHANGE because this drops to support ESLint v6.

Breaking Changes

Tasks

package.json Outdated
"eslint": "^6.4.0",
"typescript": "^3.3.3333"
"eslint": "^7.0.0",
"typescript": ">=3.3.1 <3.10.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toshi-toma Could you suggest this again because of stale?

@koba04 koba04 marked this pull request as ready for review June 15, 2020 15:25
@koba04 koba04 requested a review from a team as a code owner June 15, 2020 15:25
@koba04 koba04 requested review from pirosikick and removed request for a team June 15, 2020 15:25
@ghost ghost requested a review from zaki-yama June 15, 2020 15:25
assert.deepStrictEqual(result, {
"error.js": {
errors: [
"no-var",
"no-unused-vars",
"no-var",
"no-redeclare",
"getter-return",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of the errors is not the same between Node v10 and v12, so I temporarily disable the errors.

assert.deepStrictEqual(result, {
"error.js": {
errors: ["no-unused-vars", "no-redeclare"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of the errors is not the same between Node v10 and v12, so I temporarily disable the errors.

@koba04
Copy link
Contributor Author

koba04 commented Jun 15, 2020

eslint-plugin-node seems to work fine with ESLint v7, so I'll be able to merge this.

Copy link
Contributor

@toshi-toma toshi-toma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated
"eslint-plugin-flowtype": "^4.7.0",
"eslint-plugin-import": "^2.20.2",
"eslint-plugin-flowtype": "^5.1.3",
"eslint-plugin-import": "^2.21.2",
"eslint-plugin-jsx-a11y": "6.2.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to be released in a few minutes.

Do you want to fix this separately?
jsx-eslint/eslint-plugin-jsx-a11y#684 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toshi-toma Thanks. I've updated it to the latest version.

@koba04 koba04 merged commit 398512d into master Jun 19, 2020
@koba04 koba04 deleted the eslint-v7 branch June 19, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants