Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History pathname can no longer contain the search query and/or hash #909

Open
shesek opened this issue Oct 15, 2019 · 0 comments · May be fixed by #943
Open

History pathname can no longer contain the search query and/or hash #909

shesek opened this issue Oct 15, 2019 · 0 comments · May be fixed by #943

Comments

@shesek
Copy link
Contributor

shesek commented Oct 15, 2019

Before #890, it was possible to send { type: 'push', pathname: '/foo?bar#xyz' } to the history sink and have it properly processed by the history driver.

As of #890, now that the pathname is passed inside an object, this no longer works and requires { type: 'push', pathname: '/foo', search: '?bar', hash: 'xyz' } instead.

I guess this makes sense, but I think this should be made more clear in the changelog of v7.2.0 (and might even warrant a major version bump?).

More importantly though, this broke the captureClicks functionality for links with a search query or a hash, because captureClicks still welds the pathname/search/hash together into a single string.

shesek added a commit to Blockstream/esplora that referenced this issue Oct 15, 2019
shesek added a commit to Blockstream/esplora that referenced this issue Oct 15, 2019
Fixes a regression introduced by v7.2.0 until an upstream
fix is available. See cyclejs/cyclejs#909
shesek added a commit to shesek/cyclejs that referenced this issue Apr 22, 2020
BREAKING CHANGE: 🧨 captureClicks will no longer combine the search/hash into the pathname.

✅ Closes: cyclejs#909
@shesek shesek linked a pull request Apr 22, 2020 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants