You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before #890, it was possible to send { type: 'push', pathname: '/foo?bar#xyz' } to the history sink and have it properly processed by the history driver.
As of #890, now that the pathname is passed inside an object, this no longer works and requires { type: 'push', pathname: '/foo', search: '?bar', hash: 'xyz' } instead.
I guess this makes sense, but I think this should be made more clear in the changelog of v7.2.0 (and might even warrant a major version bump?).
More importantly though, this broke the captureClicks functionality for links with a search query or a hash, because captureClicks still welds the pathname/search/hash together into a single string.
The text was updated successfully, but these errors were encountered:
shesek
added a commit
to Blockstream/esplora
that referenced
this issue
Oct 15, 2019
Before #890, it was possible to send
{ type: 'push', pathname: '/foo?bar#xyz' }
to the history sink and have it properly processed by the history driver.As of #890, now that the pathname is passed inside an object, this no longer works and requires
{ type: 'push', pathname: '/foo', search: '?bar', hash: 'xyz' }
instead.I guess this makes sense, but I think this should be made more clear in the changelog of v7.2.0 (and might even warrant a major version bump?).
More importantly though, this broke the captureClicks functionality for links with a search query or a hash, because captureClicks still welds the pathname/search/hash together into a single string.
The text was updated successfully, but these errors were encountered: