You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Usually in the code, we use MainDOMSource as type of DOM source. And document or body sources are available from any normal DOM source are used as: DOM.select('document').events(...).
Explicit use of BodyDOMSource or DocumentDOMSource types is a very rare case only for specific components, and probably even more rare case would be expecting DOM source to be MainDOMSource | BodyDOMSource | DocumentDOMSource (which DOMSource now), even if so explicit statement of BodyDOMSource | DocumentDOMSource would be even more appropriate.
So why this common DOM source it is called MainDOMSource, why not CommonDOMSource or ElementDOMSource, prefix Main probably the shortest option and has some sense but still seems unnatural and contrived here.
So I propose to remove/deprecate MainDOMSource and rename it to DOMSource, removing union type, the rationale for this is to make reference to commonly used DOM source type more simple and conventional, as there is no real practical reason to have a union type for all kind of sources (DOMSource union type itself actually is not used in the driver's code anywhere). So DOMSource would mean normal commonly used dom source which supports isolation and etc., and there will be specific two types BodyDOMSource and DocumentDOMSource which will be explicitly used when needed.
So this is my current perspective on this situation with quite ugly/contrived name MainDOMSource, but maybe I missed something.
The text was updated successfully, but these errors were encountered:
There was a PR that introduced MainDOMSource, BodyDOMSource or DocumentDOMSource as variants of DOMSource union type (https://github.com/cyclejs/cyclejs/blob/master/dom/src/DOMSource.ts#L16)
Usually in the code, we use
MainDOMSource
as type of DOM source. Anddocument
orbody
sources are available from any normal DOM source are used as:DOM.select('document').events(...)
.Explicit use of
BodyDOMSource
orDocumentDOMSource
types is a very rare case only for specific components, and probably even more rare case would be expecting DOM source to beMainDOMSource | BodyDOMSource | DocumentDOMSource
(whichDOMSource
now), even if so explicit statement ofBodyDOMSource | DocumentDOMSource
would be even more appropriate.So why this common DOM source it is called
MainDOMSource
, why notCommonDOMSource
orElementDOMSource
, prefixMain
probably the shortest option and has some sense but still seems unnatural and contrived here.So I propose to remove/deprecate
MainDOMSource
and rename it toDOMSource
, removing union type, the rationale for this is to make reference to commonly used DOM source type more simple and conventional, as there is no real practical reason to have a union type for all kind of sources (DOMSource union type itself actually is not used in the driver's code anywhere). SoDOMSource
would mean normal commonly used dom source which supports isolation and etc., and there will be specific two typesBodyDOMSource
andDocumentDOMSource
which will be explicitly used when needed.So this is my current perspective on this situation with quite ugly/contrived name
MainDOMSource
, but maybe I missed something.The text was updated successfully, but these errors were encountered: