Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive.singlekey configuration not working as expected #57

Open
me-and opened this issue Dec 14, 2022 · 3 comments
Open

interactive.singlekey configuration not working as expected #57

me-and opened this issue Dec 14, 2022 · 3 comments
Labels

Comments

@me-and
Copy link
Member

me-and commented Dec 14, 2022

Reported at https://cygwin.com/pipermail/cygwin/2022-August/252132.html:

I update recently all cygwin packages and after that git add -p stop working correctly. (previous update I did around 2 month ago) I use mintty on Windows 10 x64, and have set git config --global interactive.singlekey true when I run this command whole terminal freeze and show message from git: warning: reading single keystrokes not supported on this platform; reading line instead mintty stop accepting any input even Ctrl-C. I tried to revert mintty and git to older version but every one available have same behavior. For now disabling singlekey make this git operation work again but this is big lose in productivity.

@me-and me-and added the bug label Dec 14, 2022
@Yankes
Copy link

Yankes commented Mar 4, 2023

I look this bug, Ctrl-C "works" but its teat as normal character and enter still is working (lack of visual feedback is confusing).
After hacking around compat/terminal.c I find that adding:

#define HAVE_DEV_TTY

fix this whole problem and interactive.singlekey it work again as advertised.

@me-and
Copy link
Member Author

me-and commented Mar 4, 2023

Ah, good to know! I'll do a bit of digging and work out how that should get plumbed in properly. I'm a bit wary of just adding the #define, in case adding it causes more problems than it solves, but that information is an incredibly useful starting point!

@Yankes
Copy link

Yankes commented Mar 5, 2023

Yes, it would be crude hack (and I plan do it for myself locally) but for more proper fix (even for main git branch) could be:
in file config.mak.uname do setting HAVE_DEV_TTY = YesPlease for Cygwin. I did not check it yet, but I hope it could work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants