Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cylc clean: continue if remote clean fails? #4935

Open
hjoliver opened this issue Jun 27, 2022 · 4 comments · May be fixed by #4950
Open

cylc clean: continue if remote clean fails? #4935

hjoliver opened this issue Jun 27, 2022 · 4 comments · May be fixed by #4950
Assignees
@hjoliver @oliver-sanders
Labels
bug
Milestone
8.x

Comments

@hjoliver
Copy link
Member

hjoliver commented Jun 27, 2022 •
edited

If cylc clean can't clean a remote job platform used (or attempted) by the target workflow, it should continue on and clean other job platforms, and locally, rather than abort immediately.

I'm reasonably sure this is a bug and not a feature(?)

E.g. install and run a workflow that uses a non-existent job platform, then try to clean it.
@hjoliver hjoliver added the bug label Jun 27, 2022
@hjoliver hjoliver added this to the cylc-8.0rc4 milestone Jun 27, 2022
@hjoliver
Copy link
Member Author

see also #4673

@oliver-sanders
Copy link
Member

oliver-sanders commented Jun 29, 2022 •
edited

It should continue onto other platforms, yes, however, it should not clean locally because doing so would delete the database prohibiting cylc clean from being able to remove the remote directory at a later date e.g. if a login node goes down.

@oliver-sanders oliver-sanders added could be better Not exactly a bug, but not ideal. bug and removed bug could be better Not exactly a bug, but not ideal. labels Jun 29, 2022
@oliver-sanders
Copy link
Member

If you try to run a task on a non-existant platform, then, ideally, cylc clean should not attempt to clean that platform since it never installed on it in the first place. But cylc clean does not have access to the remote-init map, perhaps it should, it wouldn't hurt to store remote-init events in the DB?

This was referenced Jun 30, 2022
Closed
Draft
@oliver-sanders
Copy link
Member

(taking a quick look at the broken platform side of this)

@oliver-sanders oliver-sanders mentioned this issue Jun 30, 2022
Closed
15 tasks
@hjoliver hjoliver modified the milestones: cylc-8.0rc4, cylc-8.0.0 Jul 5, 2022
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.0, cylc-8.x Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjoliver hjoliver

@oliver-sanders oliver-sanders

Labels
bug
Projects
None yet
Milestone
8.x
Development

Successfully merging a pull request may close this issue.

Clean other remotes after error. hjoliver/cylc-flow
2 participants
@hjoliver @oliver-sanders