Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdef: graph parents - absolute dependencies ignored #5845

Open
oliver-sanders opened this issue Nov 23, 2023 · 1 comment · May be fixed by #6103
Open

tdef: graph parents - absolute dependencies ignored #5845

oliver-sanders opened this issue Nov 23, 2023 · 1 comment · May be fixed by #6103
Labels
bug
Milestone
8.x

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Nov 23, 2023 •
edited

Absolute dependencies don't appear in the graph.

Example:

[scheduler]
    allow implicit tasks = True

[scheduling]
    initial cycle point = 1
    cycling mode = integer
    [[graph]]
        R1 = build
        P1 = build[^] => run

The dependency is drawn in the first cycle, but not in the subsequent ones:

Screenshot from 2023-11-23 14-24-50

But the scheduler does know about the dependency:

$ cylc show icp//2/run
title: (not given)
description: (not given)
URL: (not given)
state: waiting
prerequisites: ('-': not satisfied)
  + 1/build succeeded
outputs: ('-': not completed)
  - 2/run expired
  - 2/run submitted
  - 2/run submit-failed
  - 2/run started
  - 2/run succeeded
  - 2/run failed
@oliver-sanders oliver-sanders added this to the cylc-8.x milestone Nov 23, 2023
@oliver-sanders oliver-sanders changed the title increment_graph_window: absolute dependencies ignored tdef: graph parents/children - absolute dependencies ignored May 14, 2024
@oliver-sanders
Copy link
Member Author

oliver-sanders commented May 14, 2024 •
edited

Traced the error back to the generate_graph_parents routine which is used by increment_graph_window.

@oliver-sanders oliver-sanders changed the title tdef: graph parents/children - absolute dependencies ignored tdef: graph parents - absolute dependencies ignored May 14, 2024
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue May 14, 2024
@oliver-sanders
data store: include absolute graph edges
f3edbcd 
* Closes cylc#5845
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue May 14, 2024
@oliver-sanders
data store: include absolute graph edges
2957e50 
* Closes cylc#5845
@oliver-sanders oliver-sanders linked a pull request May 14, 2024 that will close this issue
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
8.x
Development

Successfully merging a pull request may close this issue.

data store: add absolute graph edges oliver-sanders/cylc-flow
1 participant
@oliver-sanders