feat: use cypress >= 10 examples only and remove cypress 9 examples #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… actively supported
AtofStryker
commented
Sep 5, 2023
| @@ -5,13 +5,11 @@ describe('coverage information', () => { | |||
| cy.visit('/') | |||
| }) | |||
|
|
|||
| it('calls add', () => { | |||
| it('calls add & sub', () => { | |||
There was a problem hiding this comment.
changed to be one test due to test isolation. separate test is covered in before-each-visit
cacieprins
approved these changes
Sep 6, 2023
|
required checks are updated. merging in |
nagash77
approved these changes
Sep 6, 2023
|
🎉 This PR is included in version 3.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress 9 hasn't been updated for about 18 months. To consolidate examples and reduce maintenance, these examples have been removed. The plugin has not changed, therefor this is not a breaking change.
Previously there were two testing directories,
test-cypress-oldandtest-cypress-new.test-cypress-oldwas examples written for cypress v9 and under, which has been removed.test-cypress-new, on the other hand, is cypress >=10, is current cypress. These files have been hoisted a directory up andtest-cypress-newhas been removed. additionally, thepackage.jsonfromtest-cypress-newwas merged into the root directorypackage.jsonasdevDependencies.There were also a few changes to update cypress in the root directory from v9 to v13, including some minor test isolation changes to visit beforeEach as test isolation is now enabled. Additionally, any package jsons referencing the
.bindirectory in node modules have been replaced withnpxinvocations as this is the new standard.