Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show how to compare text from two elements #188

Merged
merged 1 commit into from Jan 15, 2019

Conversation

bahmutov
Copy link
Contributor

* Text from the first element.
* @type {string}
*/
let text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be introducing TypeScript into this repo's example code or tests. This is supposed to support super beginners to our project. I wouldn't assume them to have any TypeScript knowledge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not typescript, just JSDoc comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😯

@bahmutov bahmutov merged commit 0f49490 into master Jan 15, 2019
@bahmutov
Copy link
Contributor Author

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@emilyrohrbough emilyrohrbough deleted the match-text-from-two-elements branch March 30, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants