Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reduce duration of scrollTo example to reduce chance of timeout on slow machines #479

Closed
wants to merge 3 commits into from
Closed

fix: Reduce duration of scrollTo example to reduce chance of timeout on slow machines #479

wants to merge 3 commits into from

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Apr 5, 2021 •
edited

@netlify
Copy link

netlify bot commented Apr 5, 2021 •
edited

✔️ Deploy Preview for cypress-example-kitchensink ready!

🔨 Explore the source changes: 190af1c

🔍 Inspect the deploy log: https://app.netlify.com/sites/cypress-example-kitchensink/deploys/60f1868721353400076f93e9

😎 Browse the preview: https://deploy-preview-479--cypress-example-kitchensink.netlify.app/commands/actions

@cypress
Copy link

cypress bot commented Apr 5, 2021 •
edited


Test summary

120 • 0 • 0 • 0

Run details
Project cypress-example-kitchensink
Status Passed
Commit 190af1c
Started Jul 16, 2021 2:03 PM
Ended Jul 16, 2021 2:07 PM
Duration 04:25 💡
OS Windows 10.0.17763
Browser Firefox 87

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 5, 2021 •
edited


Test summary

120 • 0 • 0 • 0

Run details
Project cypress-example-kitchensink
Status Passed
Commit 3648c9a ℹ️
Started Jul 16, 2021 1:51 PM
Ended Jul 16, 2021 2:03 PM
Duration 11:01 💡
OS Windows 10.0.17763
Browser Edge 90

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrisbreiding chrisbreiding changed the title fix: Reduce duration of scrollTo example to reduce change of timeout on slow machines fix: Reduce duration of scrollTo example to reduce chance of timeout on slow machines May 25, 2021
@chrisbreiding chrisbreiding removed their assignment Jul 16, 2021
jennifer-shehane
jennifer-shehane requested changes Jul 20, 2021
View reviewed changes
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisbreiding It looks like the scrollTo tests are still failing after this PR. See CI failures.

@BlueWinds
Copy link
Contributor

I'm going to assume this is no longer needed and close it out.

@BlueWinds BlueWinds closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane requested changes

Assignees

@chrisbreiding chrisbreiding

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.scrollTo times out in kitchensink tests
3 participants
@chrisbreiding @BlueWinds @jennifer-shehane