Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 12 deprecation warning in semantic-pull-request #611

Open
MikeMcC399 opened this issue Mar 31, 2023 · 10 comments
Open

Node.js 12 deprecation warning in semantic-pull-request #611

MikeMcC399 opened this issue Mar 31, 2023 · 10 comments

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Mar 31, 2023

Problem description

Workflow .github/workflows/semantic-pull-request.yml produces a deprecation warning, for example in 6294797314

"Lint Title
The following actions uses node12 which is deprecated and will be forced to run on node16: cypress-io/action-semantic-pull-request@v4. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/"

Analysis

.github/workflows/semantic-pull-request.yml

- uses: cypress-io/action-semantic-pull-request@v4

https://github.com/cypress-io/action-semantic-pull-request/blob/v4/action.yml v4

runs:
  using: 'node12'
  main: 'dist/index.js'

This is the latest available version on cypress-io/action-semantic-pull-request so there is no version of this fork available which specifies node16.

The parent repository amannn/action-semantic-pull-request has however been updated and there is a v5 version available which uses node20 and resolves deprecations. See CHANGELOG.

Suggestion

  1. Make v5 available on cypress-io/action-semantic-pull-request
  2. Update .github/workflows/semantic-pull-request.yml to - uses: cypress-io/action-semantic-pull-request@v5 when this is made available.
@MikeMcC399
Copy link
Contributor Author

I opened the issue here, because issues are not enabled on the https://github.com/cypress-io/action-semantic-pull-request repo. The next step would be to create a PR on https://github.com/cypress-io/action-semantic-pull-request repo to sync to v5. I am not planning to do this personally and I would rather leave this critical step to the Cypress.io team.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Sep 12, 2023

The deprecation warning has been re-instated:

The following actions uses node12 which is deprecated and will be forced to run on node16: cypress-io/action-semantic-pull-request@v4. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

so I'm re-opening the issue.

Both Node.js 12 and Node.js 16 are now in end-of-life status.

Edit: GitHub's supported strategy for Node.js versions in JavaScript actions however is not well documented at this time, so it is unclear if and when the action cypress-io/action-semantic-pull-request might stop working. It can only be identified as a risk at the moment if nothing is done to update the action. outdated

@MikeMcC399 MikeMcC399 reopened this Sep 12, 2023
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Sep 25, 2023

There is a new announcement on https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

At this time node12 actions are forced to run under node16.
By early next year 2024 all actions will be forced to run under node20.

The least-effort strategy is to monitor deprecation warnings and to make no changes unless / until something breaks.

@MikeMcC399
Copy link
Contributor Author

The workflow semantic-pull-request.yml currently provokes two deprecation warnings, here displayed first as a screenshot:

image

and here as text with hyperlinks:

  1. Lint Title
    Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: cypress-io/action-semantic-pull-request@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

  2. Lint Title
    The following actions uses node12 which is deprecated and will be forced to run on node16: cypress-io/action-semantic-pull-request@v4. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

@MikeMcC399
Copy link
Contributor Author

The GitHub blog post GitHub Actions; All Actions will run on Node20 instead of Node16 by default announces that all actions are forced to run under Node.js 20 starting on May 13, 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants