Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): migrate to eslint stylistic 1.7.2 #833

Merged

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Apr 29, 2024

Issue

The ESLint rule indent was deprecated in ESLint v8.53.0. The ESlint documentation suggests to use the corresponding rule in @stylistic/eslint-plugin-js.

This repo uses ESLint v8.57.0 and so the deprecation already applies.

Change

  1. The npm module @stylistic/eslint-plugin-js is added using the release @stylistic/eslint-plugin-js@1.7.2.
  2. The .eslintrc configuration is changed:
    1. @stylistic/js added to plugins
    2. The indent rule is changed from
      "indent": ["error", 2, { "SwitchCase": 1, "MemberExpression": "off" }],

      to
    "@stylistic/js/indent": ["error", 2, { "SwitchCase": 1, "MemberExpression": "off" }]
    

This is a refactor since the functionality remains the same, only the underlying tools are changed.

Verification

npm ci
npm run lint

Reference

replaces deprecated eslint indent rule
@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 29, 2024 12:57
@jennifer-shehane jennifer-shehane merged commit f757f7f into cypress-io:master Apr 30, 2024
13 checks passed
@MikeMcC399 MikeMcC399 deleted the migrate/eslint-indent branch May 1, 2024 05:58
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 2.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants