From 2513beac307e95267ab736a93a39cd1cd1280506 Mon Sep 17 00:00:00 2001 From: Zachary Williams Date: Tue, 8 Nov 2022 14:29:47 -0600 Subject: [PATCH] fix: vite-dev-server hoisting issue in binary (#24599) --- .circleci/config.yml | 6 +++++- npm/vite-dev-server/package.json | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ec679f49bf8a..49517d59e77f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -27,6 +27,7 @@ mainBuildFilters: &mainBuildFilters branches: only: - develop + - 'zachw/fix-vite-hoisting-issue' # usually we don't build Mac app - it takes a long time # but sometimes we want to really confirm we are doing the right thing @@ -35,6 +36,7 @@ macWorkflowFilters: &darwin-workflow-filters when: or: - equal: [ develop, << pipeline.git.branch >> ] + - equal: [ 'zachw/fix-vite-hoisting-issue', << pipeline.git.branch >> ] - matches: pattern: "-release$" value: << pipeline.git.branch >> @@ -43,6 +45,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters when: or: - equal: [ develop, << pipeline.git.branch >> ] + - equal: [ 'zachw/fix-vite-hoisting-issue', << pipeline.git.branch >> ] - matches: pattern: "-release$" value: << pipeline.git.branch >> @@ -60,6 +63,7 @@ windowsWorkflowFilters: &windows-workflow-filters when: or: - equal: [ develop, << pipeline.git.branch >> ] + - equal: [ 'zachw/fix-vite-hoisting-issue', << pipeline.git.branch >> ] - matches: pattern: "-release$" value: << pipeline.git.branch >> @@ -126,7 +130,7 @@ commands: - run: name: Check current branch to persist artifacts command: | - if [[ "$CIRCLE_BRANCH" != "develop" ]]; then + if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "zachw/fix-vite-hoisting-issue" ]]; then echo "Not uploading artifacts or posting install comment for this branch." circleci-agent step halt fi diff --git a/npm/vite-dev-server/package.json b/npm/vite-dev-server/package.json index d102af69b040..ac9f49f2a45e 100644 --- a/npm/vite-dev-server/package.json +++ b/npm/vite-dev-server/package.json @@ -15,7 +15,7 @@ "test-unit": "mocha -r ts-node/register/transpile-only --config ./test/.mocharc.js" }, "dependencies": { - "debug": "4.3.3", + "debug": "^4.3.4", "find-up": "6.3.0", "node-html-parser": "5.3.3" },