Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cypress-io/cypress
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v12.9.0
Choose a base ref
...
head repository: cypress-io/cypress
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v12.10.0
Choose a head ref
Loading
Showing with 27,553 additions and 6,798 deletions.
  1. +9 −8 .circleci/workflows.yml
  2. +1 −1 .github/workflows/semantic-pull-request.yml
  3. +4 −4 .github/workflows/stale_issues_and_pr_cleanup.yml
  4. +0 −23 .github/workflows/triage_add_stale_issue_to_board.yml
  5. +1 −1 .github/workflows/triage_add_to_project.yml
  6. +0 −104 .github/workflows/triage_closed_issue_comment.yml
  7. +32 −0 .github/workflows/triage_handle_new_comments.yml
  8. +1 −1 .github/workflows/update_v8_snapshot_cache.yml
  9. +8 −8 CONTRIBUTING.md
  10. +2 −2 browser-versions.json
  11. +32 −4 cli/CHANGELOG.md
  12. +5 −19 cli/__snapshots__/cli_spec.js
  13. +17 −21 cli/lib/cli.js
  14. +2 −3 cli/package.json
  15. +124 −144 cli/test/lib/cli_spec.js
  16. +2 −0 npm/create-cypress-tests/CHANGELOG.md
  17. +1 −1 npm/create-cypress-tests/package.json
  18. +1 −3 npm/grep/README.md
  19. +7 −0 npm/webpack-dev-server/CHANGELOG.md
  20. +22 −3 npm/webpack-dev-server/src/helpers/nextHandler.ts
  21. +0 −1 npm/webpack-preprocessor/package.json
  22. +4 −5 package.json
  23. +7 −7 packages/app/cypress/e2e/runs.cy.ts
  24. +5 −5 packages/app/index.d.ts
  25. +1 −1 packages/app/package.json
  26. +19 −4 packages/app/src/debug/DebugCommitIcon.vue
  27. +15 −3 packages/app/src/debug/DebugCurrentRunIcon.vue
  28. +3 −0 packages/app/src/debug/DebugRunNavigation.cy.tsx
  29. +0 −2 packages/app/src/graphql.ts
  30. +10 −2 packages/app/src/main.ts
  31. +11 −0 packages/app/src/runner/event-manager.ts
  32. +39 −0 packages/app/src/runner/events/telemetry.ts
  33. +34 −27 packages/app/src/runs/RunCard.vue
  34. +1 −2 packages/config/package.json
  35. +1 −1 packages/data-context/package.json
  36. +8 −0 packages/data-context/src/actions/DataEmitterActions.ts
  37. +4 −0 packages/data-context/src/actions/ProjectActions.ts
  38. +6 −1 packages/data-context/src/actions/WizardActions.ts
  39. +18 −1 packages/data-context/src/data/ProjectConfigIpc.ts
  40. +36 −1 packages/data-context/src/data/ProjectConfigManager.ts
  41. +45 −4 packages/data-context/src/data/ProjectLifecycleManager.ts
  42. +3 −1 packages/data-context/src/data/coreDataShape.ts
  43. +5 −6 packages/data-context/src/index.ts
  44. +2 −0 packages/data-context/src/sources/HtmlDataSource.ts
  45. +5 −0 packages/data-context/src/sources/UtilDataSource.ts
  46. +47 −0 packages/data-context/src/sources/VersionsDataSource.ts
  47. +74 −10 packages/data-context/test/unit/sources/VersionsDataSource.spec.ts
  48. +19 −3 packages/driver/cypress/e2e/commands/actions/{type_events_spec.js → type_events.cy.js}
  49. +0 −8 packages/driver/cypress/e2e/commands/screenshot.cy.js
  50. +1 −1 packages/driver/package.json
  51. +1 −1 packages/driver/src/cy/commands/actions/type.ts
  52. +5 −2 packages/driver/src/cypress.ts
  53. +5 −0 packages/driver/src/main.ts
  54. +1 −0 packages/driver/types/internal-types.d.ts
  55. +1 −2 packages/electron/package.json
  56. +1 −2 packages/example/package.json
  57. +0 −1 packages/extension/package.json
  58. +1 −0 packages/frontend-shared/cypress/support/mock-graphql/stubgql-Wizard.ts
  59. +0 −1 packages/frontend-shared/package.json
  60. +13 −4 packages/frontend-shared/src/components/ListRowHeader.cy.tsx
  61. +20 −11 packages/frontend-shared/src/components/ListRowHeader.vue
  62. +5 −1 packages/frontend-shared/src/locales/en-US.json
  63. +0 −1 packages/graphql/package.json
  64. +19 −0 packages/graphql/schemas/schema.graphql
  65. +1 −11 packages/graphql/src/schemaTypes/objectTypes/gql-Mutation.ts
  66. +8 −1 packages/graphql/src/schemaTypes/objectTypes/gql-Subscription.ts
  67. +7 −0 packages/graphql/src/schemaTypes/objectTypes/gql-Wizard.ts
  68. +12 −0 packages/graphql/src/schemaTypes/objectTypes/gql-WizardErroredFramework.ts
  69. +1 −0 packages/graphql/src/schemaTypes/objectTypes/index.ts
  70. +0 −1 packages/https-proxy/package.json
  71. +0 −1 packages/launcher/package.json
  72. +23 −23 packages/launchpad/cypress/e2e/config-files-error-handling.cy.ts
  73. +5 −6 packages/launchpad/cypress/e2e/config-warning.cy.ts
  74. +2 −2 packages/launchpad/cypress/e2e/migration.cy.ts
  75. +54 −9 packages/launchpad/cypress/e2e/open-mode.cy.ts
  76. +16 −5 packages/launchpad/cypress/e2e/project-setup.cy.ts
  77. +29 −0 packages/launchpad/cypress/e2e/scaffold-component-testing.cy.ts
  78. +9 −1 packages/launchpad/cypress/e2e/scaffold-project.cy.ts
  79. +4 −4 packages/launchpad/cypress/e2e/top-nav-launchpad.cy.ts
  80. +0 −1 packages/launchpad/package.json
  81. +81 −2 packages/launchpad/src/setup/EnvironmentSetup.cy.tsx
  82. +71 −5 packages/launchpad/src/setup/EnvironmentSetup.vue
  83. +10 −24 packages/launchpad/src/setup/{SelectFwOrBundler.cy.tsx → SelectFrameworkOrBundler.cy.tsx}
  84. 0 packages/launchpad/src/setup/{SelectFwOrBundler.vue → SelectFrameworkOrBundler.vue}
  85. +1 −2 packages/net-stubbing/package.json
  86. +0 −80 packages/net-stubbing/test/unit/middleware-request-spec.ts
  87. +0 −1 packages/network/package.json
  88. +0 −1 packages/proxy/package.json
  89. +0 −1 packages/reporter/package.json
  90. +1 −2 packages/resolve-dist/package.json
  91. +0 −1 packages/rewriter/package.json
  92. +0 −1 packages/runner/package.json
  93. +1 −2 packages/scaffold-config/package.json
  94. +29 −47 packages/scaffold-config/src/ct-detect-third-party.ts
  95. +1 −1 packages/scaffold-config/src/dependencies.ts
  96. +28 −3 packages/scaffold-config/src/frameworks.ts
  97. +71 −0 packages/scaffold-config/src/searchUtils.ts
  98. +6 −66 packages/scaffold-config/test/unit/ct-detect-third-party.spec.ts
  99. +105 −0 packages/scaffold-config/test/unit/searchUtils.spec.ts
  100. +3 −0 packages/server/index.js
  101. +12 −0 packages/server/lib/browsers/utils.ts
  102. +1 −0 packages/server/lib/cloud/routes.ts
  103. +19 −1 packages/server/lib/cypress.js
  104. +8 −5 packages/server/lib/modes/index.ts
  105. +10 −3 packages/server/lib/modes/interactive.ts
  106. +74 −8 packages/server/lib/modes/run.ts
  107. +9 −0 packages/server/lib/open_project.ts
  108. +24 −1 packages/server/lib/plugins/child/require_async_child.js
  109. +12 −0 packages/server/lib/plugins/child/ts_node.js
  110. +9 −1 packages/server/lib/plugins/preprocessor.js
  111. +22 −0 packages/server/lib/socket-base.ts
  112. +3 −1 packages/server/lib/util/ci_provider.js
  113. +11 −3 packages/server/lib/util/performance_benchmark.js
  114. +3 −3 packages/server/package.json
  115. +46 −5 packages/server/start-cypress.js
  116. +8 −0 packages/server/test/unit/plugins/child/ts_node_spec.js
  117. +1 −1 packages/server/test/unit/plugins/preprocessor_spec.js
  118. +4 −0 packages/server/test/unit/util/ci_provider_spec.js
  119. +1 −2 packages/socket/package.json
  120. +291 −0 packages/telemetry/README.md
  121. +36 −0 packages/telemetry/package.json
  122. +85 −0 packages/telemetry/src/browser.ts
  123. +291 −0 packages/telemetry/src/index.ts
  124. +92 −0 packages/telemetry/src/node.ts
  125. +160 −0 packages/telemetry/src/span-exporters/cloud-span-exporter.ts
  126. +86 −0 packages/telemetry/src/span-exporters/ipc-span-exporter.ts
  127. +90 −0 packages/telemetry/src/span-exporters/websocket-span-exporter.ts
  128. +9 −0 packages/telemetry/test/.mocharc.js
  129. +181 −0 packages/telemetry/test/browser.spec.ts
  130. +372 −0 packages/telemetry/test/index.spec.ts
  131. +198 −0 packages/telemetry/test/node.spec.ts
  132. +399 −0 packages/telemetry/test/span-exporters/cloud-span-exporter.spec.ts
  133. +150 −0 packages/telemetry/test/span-exporters/ipc-span-exporter.spec.ts
  134. +161 −0 packages/telemetry/test/span-exporters/websocket-span-exporter.spec.ts
  135. +16 −0 packages/telemetry/tsconfig.json
  136. +1 −3 packages/ts/package.json
  137. +0 −1 packages/types/package.json
  138. +1 −2 packages/v8-snapshot-require/package.json
  139. +19 −0 patches/resolve-package-path+4.0.3.patch
  140. +3 −4 renovate.json
  141. +2 −2 scripts/github-actions/create-pull-request.js
  142. +2 −2 scripts/github-actions/semantic-pull-request/index.js
  143. +1 −1 scripts/github-actions/semantic-pull-request/validate-pr-title.js
  144. +2 −2 scripts/github-actions/update-browser-versions.js
  145. +1 −0 scripts/gulp/monorepoPaths.ts
  146. +12 −8 scripts/unit/github-actions/create-pull-request-spec.js
  147. +9 −3 scripts/unit/github-actions/semantic-pull-request/validate-pr-title-spec.js
  148. +24 −20 scripts/unit/github-actions/update-browser-version-spec.js
  149. +11 −8 scripts/wait-on-circle-jobs.js
  150. +3 −0 system-tests/.eslintignore
  151. +12 −12 system-tests/projects/angular-13/yarn.lock
  152. +9 −9 system-tests/projects/angular-14/yarn.lock
  153. +6 −6 system-tests/projects/angular-15/yarn.lock
  154. +12 −12 system-tests/projects/angular-cli-configured/yarn.lock
  155. +12 −12 system-tests/projects/angular-cli-unconfigured/yarn.lock
  156. +33 −695 system-tests/projects/angular-custom-config/yarn.lock
  157. +3,833 −4,560 system-tests/projects/angular-custom-root/yarn.lock
  158. +9 −9 system-tests/projects/component-testing-outdated-dependencies/yarn.lock
  159. +2 −2 system-tests/projects/config-with-ts-module-error/package.json
  160. +130 −124 system-tests/projects/config-with-ts-module-error/yarn.lock
  161. +13 −22 system-tests/projects/cra-4/yarn.lock
  162. +26 −26 system-tests/projects/cra-5/yarn.lock
  163. +29 −29 system-tests/projects/cra-ejected/yarn.lock
  164. +15 −26 system-tests/projects/create-react-app-configured/yarn.lock
  165. +8 −14 system-tests/projects/create-react-app-custom-index-html/yarn.lock
  166. +21 −29 system-tests/projects/create-react-app-unconfigured/yarn.lock
  167. +1 −0 system-tests/projects/issue-25951-next-app/README.md
  168. +12 −0 system-tests/projects/issue-25951-next-app/cypress.config.ts
  169. +14 −0 system-tests/projects/issue-25951-next-app/cypress/support/component-index.html
  170. +5 −0 system-tests/projects/issue-25951-next-app/next-env.d.ts
  171. +6 −0 system-tests/projects/issue-25951-next-app/next.config.js
  172. +14 −0 system-tests/projects/issue-25951-next-app/package.json
  173. +11 −0 system-tests/projects/issue-25951-next-app/src/pages/_app.cy.tsx
  174. +5 −0 system-tests/projects/issue-25951-next-app/src/pages/_app.tsx
  175. +3 −0 system-tests/projects/issue-25951-next-app/src/styles/globals.css
  176. +24 −0 system-tests/projects/issue-25951-next-app/tsconfig.json
  177. +226 −0 system-tests/projects/issue-25951-next-app/yarn.lock
  178. +1 −1 system-tests/projects/missing-vite-config/package.json
  179. +4 −4 system-tests/projects/missing-vite-config/yarn.lock
  180. +463 −24 system-tests/projects/nextjs-configured/yarn.lock
  181. +275 −19 system-tests/projects/nextjs-unconfigured/yarn.lock
  182. +9 −9 system-tests/projects/no-specs-custom-pattern/yarn.lock
  183. +12 −12 system-tests/projects/no-specs-vue-2/yarn.lock
  184. +13 −22 system-tests/projects/no-specs/yarn.lock
  185. +21 −23 system-tests/projects/nuxtjs-vue2-configured/yarn.lock
  186. +12 −18 system-tests/projects/nuxtjs-vue2-unconfigured/yarn.lock
  187. +12 −18 system-tests/projects/nuxtjs2/yarn.lock
  188. +3 −3 system-tests/projects/outdated-deps-vuecli3/yarn.lock
  189. +3 −3 system-tests/projects/plugin-code-coverage/yarn.lock
  190. +10 −0 system-tests/projects/qwik-app/cypress-ct-bad-missing-value/definition.js
  191. +3 −0 system-tests/projects/qwik-app/cypress-ct-bad-missing-value/index.js
  192. +22 −0 system-tests/projects/qwik-app/cypress-ct-bad-missing-value/package.json
  193. +1 −0 system-tests/projects/qwik-app/cypress-ct-bad-syntax/definition.js
  194. +3 −0 system-tests/projects/qwik-app/cypress-ct-bad-syntax/index.js
  195. +7 −0 system-tests/projects/qwik-app/cypress-ct-bad-syntax/package.json
  196. +12 −0 system-tests/projects/ts-proj-5/cypress.config.ts
  197. +6 −0 system-tests/projects/ts-proj-5/cypress/e2e/app.cy.ts
  198. +3 −0 system-tests/projects/ts-proj-5/cypress/e2e/math.ts
  199. +3 −0 system-tests/projects/ts-proj-5/cypress/support/component-index.html
  200. +20 −0 system-tests/projects/ts-proj-5/cypress/support/e2e.ts
  201. +9 −0 system-tests/projects/ts-proj-5/package.json
  202. +7 −0 system-tests/projects/ts-proj-5/src/foo.cy.ts
  203. +5 −0 system-tests/projects/ts-proj-5/tsconfig.json
  204. +232 −0 system-tests/projects/ts-proj-5/yarn.lock
  205. +1 −1 system-tests/projects/vite-ct-object-api/package.json
  206. +155 −131 system-tests/projects/vite-ct-object-api/yarn.lock
  207. +12,852 −0 system-tests/projects/yarn-v3.1.1-pnp/.pnp.cjs
  208. +249 −0 system-tests/projects/yarn-v3.1.1-pnp/.pnp.loader.mjs
  209. +4 −2 system-tests/projects/yarn-v3.1.1-pnp/package.json
  210. +1,488 −0 system-tests/projects/yarn-v3.1.1-pnp/yarn.lock
  211. +8 −0 system-tests/test/component_testing_spec.ts
  212. +7 −0 system-tests/test/typescript_plugins_spec.ts
  213. +617 −2 tooling/v8-snapshot/cache/darwin/snapshot-meta.json
  214. +617 −2 tooling/v8-snapshot/cache/linux/snapshot-meta.json
  215. +619 −2 tooling/v8-snapshot/cache/win32/snapshot-meta.json
  216. +0 −1 tooling/v8-snapshot/package.json
  217. +944 −48 yarn.lock
17 changes: 9 additions & 8 deletions .circleci/workflows.yml
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ mainBuildFilters: &mainBuildFilters
- /^release\/\d+\.\d+\.\d+$/
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- 'update-v8-snapshot-cache-on-develop'
- 'emily/before-spec-promise'
- 'matth/misc/telemetry'

# usually we don't build Mac app - it takes a long time
# but sometimes we want to really confirm we are doing the right thing
@@ -41,7 +41,6 @@ macWorkflowFilters: &darwin-workflow-filters
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'emily/before-spec-promise', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
@@ -52,7 +51,6 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'fix/preflight', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
@@ -71,9 +69,8 @@ windowsWorkflowFilters: &windows-workflow-filters
or:
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'lmiller/fixing-vite-windows', << pipeline.git.branch >> ]
- equal: [ 'windows-flake', << pipeline.git.branch >> ]
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'fix/preflight', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
@@ -139,7 +136,7 @@ commands:
- run:
name: Check current branch to persist artifacts
command: |
if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "emily/before-spec-promise" && "$CIRCLE_BRANCH" != "update-v8-snapshot-cache-on-develop" ]]; then
if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "update-v8-snapshot-cache-on-develop" ]]; then
echo "Not uploading artifacts or posting install comment for this branch."
circleci-agent step halt
fi
@@ -495,6 +492,8 @@ commands:
if [[ -v MAIN_RECORD_KEY ]]; then
# internal PR
CYPRESS_RECORD_KEY=$MAIN_RECORD_KEY \
CYPRESS_INTERNAL_ENABLE_TELEMETRY="true" \
OTEL_RESOURCE_ATTRIBUTES="ci.branch=$CIRCLE_BRANCH,ci.job=$CIRCLE_JOB,ci.node-index=$CIRCLE_NODE_INDEX,ci.circle=$CIRCLECI,ci.build-url=$CIRCLE_BUILD_URL,ci.build-number=$CIRCLE_BUILD_NUM" \
yarn cypress:run --record --parallel --group 5x-driver-<<parameters.browser>> --browser <<parameters.browser>>
else
# external PR
@@ -567,6 +566,8 @@ commands:
PERCY_PARALLEL_NONCE=$CIRCLE_WORKFLOW_WORKSPACE_ID \
PERCY_ENABLE=${PERCY_TOKEN:-0} \
PERCY_PARALLEL_TOTAL=-1 \
CYPRESS_INTERNAL_ENABLE_TELEMETRY="true" \
OTEL_RESOURCE_ATTRIBUTES="ci.branch=$CIRCLE_BRANCH,ci.job=$CIRCLE_JOB,ci.node-index=$CIRCLE_NODE_INDEX,ci.circle=$CIRCLECI,ci.build-url=$CIRCLE_BUILD_URL,ci.build-number=$CIRCLE_BUILD_NUM" \
$cmd yarn workspace @packages/<<parameters.package>> cypress:run:<<parameters.type>> --browser <<parameters.browser>> --record --parallel --group <<parameters.package>>-<<parameters.type>>
else
# external PR
@@ -1307,7 +1308,7 @@ jobs:
<<: *defaultsParameters
steps:
- restore_cached_workspace
- run:
- run:
name: 'Determine if Release Workflow should be triggered'
command: |
if [[ "$CIRCLE_BRANCH" != "develop" ]]; then
@@ -1455,7 +1456,7 @@ jobs:
# run type checking for each individual package
- run: yarn lerna run types
- verify-mocha-results:
expectedResultCount: 18
expectedResultCount: 19
- store_test_results:
path: /tmp/cypress
# CLI tests generate HTML files with sample CLI command output
2 changes: 1 addition & 1 deletion .github/workflows/semantic-pull-request.yml
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ jobs:
working-directory: scripts/github-actions/semantic-pull-request/
- name: Lint PR Title and Cypress Changelog Entry
if: github.event_name == 'pull_request_target'
uses: actions/github-script@v4
uses: actions/github-script@v6
with:
script: |
const verifyPullRequest = require('./scripts/github-actions/semantic-pull-request')
8 changes: 4 additions & 4 deletions .github/workflows/stale_issues_and_pr_cleanup.yml
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ on:
debug-only:
description: 'debug-only'
required: false
default: true
default: false
days-before-stale:
description: 'days-before-stale'
required: false
@@ -31,8 +31,8 @@ env:
DEFAULT_DEBUG_ONLY: true
DEFAULT_DAYS_BEFORE_STALE: 180
DEFAULT_DAYS_BEFORE_CLOSE: 14
DEFAULT_EXEMPT_ISSUE_LABELS: 'type: feature,type: enhancement,routed-to-e2e,routed-to-ct,routed-to-tools,routed-to-cloud,Popular Issue'
DEFAULT_EXEMPT_PR_LABELS: 'type: feature,type: enhancement,Popular Issue'
DEFAULT_EXEMPT_ISSUE_LABELS: 'type: feature,type: enhancement,routed-to-e2e,routed-to-ct,routed-to-tools,routed-to-cloud,Popular Issue,prevent-stale'
DEFAULT_EXEMPT_PR_LABELS: 'type: feature,type: enhancement,Popular Issue,prevent-stale'
jobs:
stale:
runs-on: ubuntu-latest
@@ -50,5 +50,5 @@ jobs:
exempt-issue-labels: ${{ github.event.inputs.exempt-issue-labels || env.DEFAULT_EXEMPT_ISSUE_LABELS }}
exempt-pr-labels: ${{ github.event.inputs.exempt-pr-labels || env.DEFAULT_EXEMPT_PR_LABELS }}
exempt-all-milestones: true
operations-per-run: 1000 #using during debug mode to capture all the tickets impacted
operations-per-run: 200 #keeping this a bit higher because it processes newest tickets to oldest
debug-only: ${{ github.event.inputs.debug-only || env.DEFAULT_DEBUG_ONLY }}
23 changes: 0 additions & 23 deletions .github/workflows/triage_add_stale_issue_to_board.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/triage_add_to_project.yml
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ jobs:
echo 'IS_COLLABORATOR='$(jq -r '.data.repository.collaborators.totalCount' collaborators.json) >> $GITHUB_ENV
- uses: actions/add-to-project@v0.4.1
# only add issues/prs from outside contributors to the project
if: ${{ env.IS_COLLABORATOR == 0 }}
if: ${{ env.IS_COLLABORATOR == 0 || github.event.repository.name == 'cypress-support-internal' || github.event.pull_request.user.login == 'github-actions[bot]' || github.event.issue.user.login == 'github-actions[bot]' }}
with:
project-url: https://github.com/orgs/${{github.repository_owner}}/projects/${{env.PROJECT_NUMBER}}
github-token: ${{ secrets.ADD_TO_TRIAGE_BOARD_TOKEN }}
104 changes: 0 additions & 104 deletions .github/workflows/triage_closed_issue_comment.yml

This file was deleted.

32 changes: 32 additions & 0 deletions .github/workflows/triage_handle_new_comments.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: 'Handle Issue/PR Comment Workflow'
on:
# makes this workflow reusable
workflow_call:
secrets:
TRIAGE_BOARD_TOKEN:
required: true

issue_comment:
types: [created]

jobs:
handle-comment-scenarios:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
with:
repository: 'cypress-io/release-automations'
ref: 'master'
ssh-key: ${{ secrets.WORKFLOW_DEPLOY_KEY }}
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: '16'
- name: Run comment_workflow.js Script
uses: actions/github-script@v6
with:
github-token: ${{ secrets.TRIAGE_BOARD_TOKEN }}
script: |
const script = require('./scripts/triage/comment_workflow.js')
await script.handleComment(github, context);
2 changes: 1 addition & 1 deletion .github/workflows/update_v8_snapshot_cache.yml
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ jobs:
strategy:
max-parallel: 1
matrix:
platform: [ubuntu-latest, windows-latest, macos-latest]
platform: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.platform }}
env:
CYPRESS_BOT_APP_ID: ${{ secrets.RAM_APP }}
16 changes: 8 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@ Thanks for taking the time to contribute! :smile:

## Code of Conduct

All contributors are expecting to abide by our [Code of Conduct](./CODE_OF_CONDUCT.md).
All contributors are expected to abide by our [Code of Conduct](./CODE_OF_CONDUCT.md).

## Opening Issues

@@ -112,7 +112,7 @@ video | Problems with video recordings | [open](https://github.com/cypress-io/cy


## Writing Documentation

Cypress documentation lives in a separate repository with its own dependencies and build tools.
See [Documentation Contributing Guidelines](https://github.com/cypress-io/cypress-documentation/blob/master/CONTRIBUTING.md).

@@ -155,7 +155,7 @@ Here is a list of the core packages in this repository with a short description,
| [proxy](./packages/proxy) | `@packages/proxy` | Code for Cypress' network proxy layer. |
| [reporter](./packages/reporter) | `@packages/reporter` | The reporter shows the running results of the tests (The Command Log UI). |
| [resolve-dist](./packages/resolve-dist) | `@packages/resolve-dist` | Centralizes the resolution of paths to compiled/static assets from server-side code.. |
| [rewriter](./packages/rewriter) | `@packages/rewriter` | The logic to rewrite JS and HTML that flows through the Cypress proxy.
| [rewriter](./packages/rewriter) | `@packages/rewriter` | The logic to rewrite JS and HTML that flows through the Cypress proxy.
| [root](./packages/root) | `@packages/root` | Dummy package pointing at the root of the repository. |
| [runner](./packages/runner) | `@packages/runner` | (deprecated) The runner is the minimal "chrome" around the user's application under test. |
| [scaffold-config](./packages/scaffold-config) | `@packages/scaffold-config` | The logic related to scaffolding new projects using launchpad. |
@@ -318,13 +318,13 @@ Each package is responsible for building itself and testing itself and can do so
When executing top or package level scripts, [Vite](https://vitejs.dev/) may be used to build/host parts of the application. This section is to serve as a general reference for these environment variables that may be leverage throughout the repository.
###### `CYPRESS_INTERNAL_VITE_DEV`
Set to `1` if wanting to leverage [vite's](https://vitejs.dev/guide/#command-line-interface) `vite dev` over `vite build` to avoid a full [production build](https://vitejs.dev/guide/build.html).
###### `CYPRESS_INTERNAL_VITE_INSPECT`
###### `CYPRESS_INTERNAL_VITE_INSPECT`
Used internally to leverage [vite-plugin-inspect](https://github.com/antfu/vite-plugin-inspect) to view intermediary vite plugin state. The `CYPRESS_INTERNAL_VITE_DEV` is required for this to be applied correctly. Set to `1` to enable.
###### `CYPRESS_INTERNAL_VITE_OPEN_MODE_TESTING`
###### `CYPRESS_INTERNAL_VITE_OPEN_MODE_TESTING`
Leveraged only for internal cy-in-cy type tests to access the Cypress instance from the parent frame. Please see the [E2E Open Mode Testing](./guides/e2e-open-testing.md) Guide. Set to `true` when doing
###### `CYPRESS_INTERNAL_VITE_APP_PORT`
###### `CYPRESS_INTERNAL_VITE_APP_PORT`
Leveraged only when `CYPRESS_INTERNAL_VITE_DEV` is set to spawn the vite dev server for the app on the specified port. The default port is `3333`.
###### `CYPRESS_INTERNAL_VITE_LAUNCHPAD_PORT`
###### `CYPRESS_INTERNAL_VITE_LAUNCHPAD_PORT`
Leveraged only when `CYPRESS_INTERNAL_VITE_DEV` is set to spawn the vite dev server for the launchpad on the specified port. The default port is `3001`.
#### Debug Logs

@@ -443,7 +443,7 @@ We do not continuously deploy the Cypress binary, so `develop` contains all of t
- After the PR is approved, the original contributor can merge the PR (if the original contributor has access).
- When you merge a PR into `develop`, select [**Squash and merge**](https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-pull-request-commits). This will squash all commits into a single commit.

*The only exceptions to squashing are:*
*The only exceptions to squashing are:*

1. When converting files to another language and there is a clear commit history needed to maintain from the file conversion.
2. When merging a `release/*` branch to `develop`. Individual PRs were already squashed when they were merged to the release branch, and we want that history intact on develop.
4 changes: 2 additions & 2 deletions browser-versions.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"chrome:beta": "112.0.5615.29",
"chrome:stable": "111.0.5563.64",
"chrome:beta": "113.0.5672.24",
"chrome:stable": "112.0.5615.49",
"chrome:minimum": "64.0.3282.0"
}
Loading