Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Node 8 to build on Windows and Mac CIs #1390

Closed
bahmutov opened this issue Feb 28, 2018 · 2 comments
Closed

Use Node 8 to build on Windows and Mac CIs #1390

bahmutov opened this issue Feb 28, 2018 · 2 comments
Assignees
@bahmutov
Labels
CI General issues involving running in a CI provider
Milestone
2.1.0

Comments

@bahmutov
Copy link
Contributor

We build the Linux binary using same major version of Node as the Electron itself is using (8), but Windows and Mac CIs are still using Node 6, which leads to wrong version of Node-sass included. This causes problems like #1387 and cypress-io/cypress-vue-unit-test#18

  • Use Node 8 on AppVeyor CI
  • Use Node 8 on Buildkite CI
@bahmutov bahmutov self-assigned this Feb 28, 2018
@bahmutov bahmutov added this to the 2.0.5 milestone Feb 28, 2018
bahmutov added a commit that referenced this issue Feb 28, 2018
@bahmutov
ci: use Node 8.2.1 to build binary on Windows CI #1390
3b17383
bahmutov added a commit that referenced this issue Feb 28, 2018
@bahmutov
ci: use Node 8.2.1 to build binary on Windows CI #1390 (#1391)
586d677 
* ci: use Node 8.2.1 to build binary on Windows CI #1390

* use Node 8.2.1 on Mac buildkite

* add comment

* source bashrc

* print home folder

* do not source bashrc

* install nvm using curl

* back to nvm using bash_profile

* hmm, maybe it is using different shell

* hmm, login into bash

* remove nvm commands

* chore: add script to check Node version against .node-version
@brian-mann brian-mann modified the milestones: 2.0.5, 2.1.0 Mar 1, 2018
@brian-mann brian-mann mentioned this issue Mar 1, 2018
Closed
@brian-mann
Copy link
Member

Fixed by #1391

@brian-mann
Copy link
Member

Released in 2.1.0.

@jennifer-shehane jennifer-shehane added CI General issues involving running in a CI provider and removed CI: appveyor labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahmutov bahmutov

Labels
CI General issues involving running in a CI provider
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@brian-mann @jennifer-shehane @bahmutov