Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode not auto discovered for file opener preference in Windows 10 #15080

Closed
diminutivesloop opened this issue Feb 12, 2021 · 3 comments · Fixed by #16355
Closed

VSCode not auto discovered for file opener preference in Windows 10 #15080

diminutivesloop opened this issue Feb 12, 2021 · 3 comments · Fixed by #16355
Assignees
Labels
OS: windows type: unexpected behavior User expected result, but got another

Comments

@diminutivesloop
Copy link

Current behavior

When changing the File Opener Preference from the test runner GUI on my Windows 10 machine I must manually specify the path to the executable for VSCode.

Desired behavior

VSCode should be auto discovered and listed as an option. I believe this is because Cypress expects the VSCode executable to be named code.exe as defined in env-editors.ts. However on my Windows 10 machine the VSCode cli command is installed as code with no .exe extension.

U:\>where code
C:\Users\npalmer\AppData\Local\Programs\Microsoft VS Code\bin\code
C:\Users\npalmer\AppData\Local\Programs\Microsoft VS Code\bin\code.cmd

U:\>where code.exe
INFO: Could not find files for the given pattern(s).

I don't recall having modified this so I assume this is the same for other VSCode users on Windows 10.

Versions

Cypress 6.4.0
VSCode 1.53.2 (user setup)
Windows 10 (18363.1256)

@jennifer-shehane
Copy link
Member

Yes, I can see this on my Windows machine also. I just installed VS Code to the default folder and it is not found by Cypress by default.

@jennifer-shehane jennifer-shehane added stage: ready for work The issue is reproducible and in scope type: unexpected behavior User expected result, but got another labels May 5, 2021
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels May 5, 2021
@jennifer-shehane jennifer-shehane self-assigned this May 6, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 10, 2021

The code for this is done in cypress-io/cypress#16355, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels May 10, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 10, 2021

Released in 7.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
OS: windows type: unexpected behavior User expected result, but got another
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants