Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address performance issues with video recording in Chrome 89+/Electron 12+ #16152

Closed
flotwig opened this issue Apr 22, 2021 · 2 comments · Fixed by #17408
Closed

Address performance issues with video recording in Chrome 89+/Electron 12+ #16152

flotwig opened this issue Apr 22, 2021 · 2 comments · Fixed by #17408
Assignees
Labels
type: performance 🏃‍♀️ Performance related type: regression A bug that didn't appear until a specific Cy version release v7.0.0 🐛 Issue present since 7.0.0

Comments

@flotwig
Copy link
Contributor

flotwig commented Apr 22, 2021

Current behavior

We cannot upgrade to Electron 12 because of a major slowdown when video recording is enabled. We are stuck on 12.0.0-beta.14, the last version before the issue appeared.

The issue appears to be related to the Chrome 89 upgrade that occurred in 12.0.0-beta.16. Similar slowdowns occur when video recording in Cypress with Chrome 89, regardless of Electron version.

With some changes released after Chromium 89.0.4328.0 and before/at 89.0.4336.0, capturing screencasts via CDP is now causing performance issues. It seems like our CDP client is receiving many, many more frames before, to the point where the user's CPU is saturated with transmitting/encoding video frames, especially when users run in resource-constrained machines in CI.

The issue can be reproduced by changing the Chrome version as well, independently of Electron's CDP.

Desired behavior

Slowdown is isolated and fixed so that we can continue to ship the latest Electron version.

Relevant:

@flotwig flotwig added type: performance 🏃‍♀️ Performance related type: regression A bug that didn't appear until a specific Cy version release v7.0.0 🐛 Issue present since 7.0.0 labels Apr 22, 2021
@flotwig flotwig self-assigned this Apr 27, 2021
@flotwig flotwig changed the title Unblock upgrading to latest Electron 12 because of performance issue Address performance issues with video recording in Chrome 89+/Electron 12+ Jun 21, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 9, 2021

The code for this is done in cypress-io/cypress#17408, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 16, 2021

Released in 8.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: performance 🏃‍♀️ Performance related type: regression A bug that didn't appear until a specific Cy version release v7.0.0 🐛 Issue present since 7.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant