Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Studio intro modal styling is showing incorrectly #17102

Closed
jennifer-shehane opened this issue Jun 24, 2021 · 2 comments · Fixed by #17118
Closed

The Studio intro modal styling is showing incorrectly #17102

jennifer-shehane opened this issue Jun 24, 2021 · 2 comments · Fixed by #17118
Assignees
@panzarino
Labels
experiment: studio Issues when using experimentalStudio type: regression A bug that didn't appear until a specific Cy version release v7.6.0 🐛 Issue present since 7.6.0

Comments

@jennifer-shehane
Copy link
Member

Current behavior

The styling of the Studio modal when first shown if not showing correctly. This was introduced in 7.6.0.

Screen Shot 2021-06-24 at 8 49 45 AM

Desired behavior

Screen Shot 2021-06-24 at 9 09 37 AM

Test code to reproduce

  • Install Cypress 7.6.0
  • Within Cypress App Data, remove showedStudioModal value.
  • Set experimentalStudio to true in cypress.json
  • Run cypress open and click to 'Create command' via the Cypress Studio

Versions

7.6.0
@jennifer-shehane jennifer-shehane added type: regression A bug that didn't appear until a specific Cy version release v7.6.0 🐛 Issue present since 7.6.0 stage: ready for work The issue is reproducible and in scope experiment: studio Issues when using experimentalStudio labels Jun 24, 2021
@panzarino panzarino self-assigned this Jun 25, 2021
@panzarino panzarino mentioned this issue Jun 25, 2021
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope labels Jun 25, 2021
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jun 30, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 30, 2021

The code for this is done in cypress-io/cypress#17118, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 7, 2021

Released in 7.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@panzarino panzarino

Labels
experiment: studio Issues when using experimentalStudio type: regression A bug that didn't appear until a specific Cy version release v7.6.0 🐛 Issue present since 7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(studio): restore intro modal styles cypress-io/cypress
2 participants
@jennifer-shehane @panzarino