fix(cli): Respect NO_PROXY on cypress download #17702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westarne
requested review from
flotwig and
chrisbreiding
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
|
|
westarne
changed the title
flotwig
suggested changes
Aug 11, 2021
flotwig
suggested changes
Sep 14, 2021
There was a problem hiding this comment.
I added a commit to add proxy-from-env@1.0.0 to package.json.
Also, can you please open a PR in cypress-documentation to enhance the install docs with this information? This would be a good place: https://github.com/cypress-io/cypress-documentation/blob/master/content/guides/getting-started/installing-cypress.md
Once that's done this looks good to me.
|
Thank you @flotwig |
flotwig
changed the title
thlorenz
added a commit
to thlorenz/cypress
that referenced
this pull request
Sep 20, 2021
* develop: fix(cli): Respect NO_PROXY on cypress download (cypress-io#17702) chore: Update Chrome (beta) to 94.0.4606.50 (cypress-io#18117) release 8.4.1 [skip ci] fix: GH env variable for test other projects (cypress-io#18147) fix(open_project): remove unnecessary fn wrapping from tryToCalls (cypress-io#18146)
tgriesser
added a commit
that referenced
this pull request
Sep 24, 2021
…/remove-decorators * unified-desktop-gui: fixing broken ct tests fix types remove old code chore: bump deps (#18213) feat(app): icon library supporting Cy's custom icons (#18195) feat(app): adding navigation, pages, router, and layout (#18194) chore: Update Chrome (stable) to 94.0.4606.54 (#18196) chore: bump yarn.lock (#18204) chore(tests): fix flake in net stubbing/xhr/proxy logging tests (#18163) chore: Update Chrome (beta) to 94.0.4606.54 (#18174) fix: add deprecation notice for win 32-bit (#18130) chore: fix broken firefox focus tests, bump resource class of chrome-beta job (#18133) fix(cli): Respect NO_PROXY on cypress download (#17702) chore: Update Chrome (beta) to 94.0.4606.50 (#18117) release 8.4.1 [skip ci] fix: GH env variable for test other projects (#18147) fix(open_project): remove unnecessary fn wrapping from tryToCalls (#18146) change @ts-expect-error -> @ts-ignore (#18047)
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
As stated in the open issue, the download of cypress did not support the
NO_PROXYenvironment variable and thus always used a proxy. This PR fixes that behaviour by adding an explicit NO_PROXY lookup. This change is based on https://github.com/cypress-io/request/blob/master/lib/getProxyFromURI.js.Additional details
I've selected this approach to still explicitly hand in the proxy to the
requestmodule, because in there the variablesnpm_config_proxyandnpm_config_https_proxyare ignored to determine the proxy.As alternative stated in #6304 (comment) it would also be possible to leave out the
proxyparameter when executing therequestas it will be determined in there. But as mentioned this would not respect the npm config properties.How has the user experience changed?
npm install cypressnow works if a proxy is set but not used for cypress.PR Tasks