Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hooks can rerun on unrelated tests after top navigation #17705

Closed
kuceb opened this issue Aug 11, 2021 · 3 comments · Fixed by #17884
Closed

hooks can rerun on unrelated tests after top navigation #17705

kuceb opened this issue Aug 11, 2021 · 3 comments · Fixed by #17884
Assignees
@kuceb
Labels
v8.2.0 🐛 Issue present since 8.2.0

Comments

@kuceb
Copy link
Contributor

kuceb commented Aug 11, 2021 •
edited

Current behavior

example: session_spec running hooks multiple times after navigation: https://app.circleci.com/pipelines/github/cypress-io/cypress/22975/workflows/4a639267-6eda-4e78-84b6-5c1f3426f04e/jobs/845803/parallel-runs/7

This occurs when a global before/after hook is present

Desired behavior

before/after hooks should only be run once and on correct suite

Test code to reproduce

n/a

Cypress Version

8.2.0

Other

No response
@kuceb kuceb changed the title hooks can rerun on unrelated tests after top navigation due to cy.visit hooks can rerun on unrelated tests after top navigation Aug 11, 2021
@kuceb kuceb self-assigned this Aug 11, 2021
@jennifer-shehane jennifer-shehane added the v8.2.0 🐛 Issue present since 8.2.0 label Aug 16, 2021
@kuceb kuceb mentioned this issue Aug 25, 2021
Merged
6 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Aug 25, 2021
@jennifer-shehane jennifer-shehane mentioned this issue Aug 30, 2021
Closed
@c32hedge c32hedge mentioned this issue Aug 31, 2021
Open
@c32hedge
Copy link

Please be sure to also check the case of visiting multiple superdomains, as described in #17940

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Sep 1, 2021
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Sep 9, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 9, 2021

The code for this is done in cypress-io/cypress#17884, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 13, 2021

Released in 8.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kuceb kuceb

Labels
v8.2.0 🐛 Issue present since 8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: global hooks cause duplicated hooks after domain navigation cypress-io/cypress
3 participants
@jennifer-shehane @c32hedge @kuceb