Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Cypress.Cookies.preserveOnce and Cypress.Cookies.defaults as deprecated #21333

Closed
mjhenkes opened this issue May 4, 2022 · 2 comments · Fixed by #21455
Closed

Mark Cypress.Cookies.preserveOnce and Cypress.Cookies.defaults as deprecated #21333

mjhenkes opened this issue May 4, 2022 · 2 comments · Fixed by #21455
Assignees
@mschile
Milestone
experimentalSessi...

Comments

@mjhenkes
Copy link
Member

mjhenkes commented May 4, 2022 •
edited

What would you like?

Warn users on usage of Cookies.preserveOnce() and Cookies.defaults() that they will be removed in a future release.

The message should also direct users on what to use instead.

Why is this needed?

Cookies.preserveOnce() and Cookies.defaults() will be removed in the Cypress 11.0 release. So we should warn users before that time.

Other
@chrisbreiding chrisbreiding changed the title Mark cookies.preserve.once and cookies.default as deprecated Mark Cypress.Cookies.preserveOnce and Cypress.Cookies.defaults as deprecated May 4, 2022
@mjhenkes mjhenkes added this to the 11.0 milestone May 6, 2022
@mschile mschile mentioned this issue May 12, 2022
Merged
3 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: backlog labels May 12, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 16, 2022

The code for this is done in cypress-io/cypress#21455, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels May 16, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2022

Released in 9.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mschile mschile

Labels
None yet
Projects
None yet
Milestone
experimentalSessionAndOrigin GA
Development

Successfully merging a pull request may close this issue.

chore: deprecate Cypress.Cookies.preserveOnce and Cypress.Cookies.defaults cypress-io/cypress
2 participants
@mjhenkes @mschile