Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sessions: Fix Failed Validation Log Message #21377

Closed
emilyrohrbough opened this issue May 6, 2022 · 2 comments · Fixed by #21379
Closed

Sessions: Fix Failed Validation Log Message #21377

emilyrohrbough opened this issue May 6, 2022 · 2 comments · Fixed by #21379
Assignees
@emilyrohrbough
Labels
topic: session Issues when using session command
Milestone
experimentalSessi...

Comments

@emilyrohrbough
Copy link
Member

emilyrohrbough commented May 6, 2022 •
edited

Current behavior

Some cases do not say “invalid” correctly

Desired behavior

Failed validation messaging is consistent. Notice in the recreated session the first validation failure reads Validate Session: invalid where the second validation group log reads Validate Session.

Screen Shot 2022-05-06 at 4 40 10 PM

Screen Shot 2022-05-06 at 4 39 55 PM

Cypress Version

9.6.0

Other

No response
@emilyrohrbough emilyrohrbough mentioned this issue May 6, 2022
Merged
5 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: internal and removed stage: needs review The PR code is done & tested, needs review labels May 6, 2022
@emilyrohrbough emilyrohrbough self-assigned this May 6, 2022
@emilyrohrbough emilyrohrbough added the topic: session Issues when using session command label May 9, 2022
@emilyrohrbough emilyrohrbough mentioned this issue May 9, 2022
Closed
@mjhenkes mjhenkes added this to the 11.0 milestone May 9, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 11, 2022

The code for this is done in cypress-io/cypress#21379, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2022

Released in 9.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@emilyrohrbough emilyrohrbough

Labels
topic: session Issues when using session command
Projects
None yet
Milestone
experimentalSessionAndOrigin GA
Development

Successfully merging a pull request may close this issue.

fix(sessions): refactor flows, fix grouping bugs and align validation fail text cypress-io/cypress
2 participants
@mjhenkes @emilyrohrbough