Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installing development NPM package by commit simpler #2312

Closed
bahmutov opened this issue Aug 9, 2018 · 1 comment
Closed

Make installing development NPM package by commit simpler #2312

bahmutov opened this issue Aug 9, 2018 · 1 comment
Assignees
Labels

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Aug 9, 2018

We can install and test development versions of cypress using TGZ npm package and custom binary path, but it is a huge hustle.

CYPRESS_BINARY_PATH=https://cdn.cypress.io/beta/binary/3.1.0/mac64/buildkite-develop-4ead424d4c9e3d65422c71597496539290720057-32310/cypress.zip npm i https://cdn.cypress.io/beta/npm/3.1.0/circle-develop-4ead424d4c9e3d65422c71597496539290720057-32306/cypress.tgz

It would be so much simpler if we could install NPM package and binary by using just a single TGZ url with commit SHA or at least branch name plus SHA

Something like: npm i -D https://on.cypress.io/beta/develop/4ead424d4c9e3d65422c71597496539290720057 where develop is branch name followed by SHA

The redirect service redirect to cypress.tgz stored on cdn.cypress.io/beta/npm/... then our NPM package would be smart to look at the original installation URL before looking at CYPRESS_BINARY etc

I did an experiment and NPM gives the original installation URL / path as an environment variable to the post install script, see https://github.com/bahmutov/test-npm-install-from-tgz. Thus the NPM package could determine its branch and SHA by inspecting npm_config_argv object, then download the right binary (we have to update on.cypress.io to make this more convenient)

This will make testing development version of test runner so so simple

@jennifer-shehane
Copy link
Member

Closing in favor of #4525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants