Wrong type definition for 'match' - removes 'string', should be 'RegExp'

[Akxe]

Current behaviour:

'match' requires its argument be a 'RegExp'. You passed 'https://example.com'.

Desired behaviour:

Since in type anotation is as fallow:

/**
 * Asserts that the target matches the given regular expression `re`.
 * @example
 *    cy.wrap('foobar').should('match', /^foo/)
 * @see http://chaijs.com/api/bdd/#method_match
 * @see https://on.cypress.io/assertions
 */
(chainer: 'match', value: string | RegExp): Chainable<Subject>

I would assume it would take string. Since it is match I thought it would use String.match function...

Steps to reproduce:

context('test', () => {
	it('test', () => {
		cy.wrap('hello world').should('match', 'wolrd')
	})
})

Versions

Cypress: 3.1.0
OS: Windows 10
Browser: Chrome 69.x.x

[chrisbreiding]

Looks like we have the type annotation wrong.

This is part of chai and is documented to only accept a RegExp. This follows the String.prototype.match signature.

For matching a substring, you can use include instead:

cy.wrap('hello world').should('include', 'wolrd')

[Akxe]

Sure I used contain, but it should be corrected non the less.

…

---------- Původní zpráva ---------- Od: Chris Breiding Datum: 9. 10. 2018 v 18:49:30 Předmět: Re: [cypress-io/cypress] 'match' requires its argument be a 'RegExp' (#2578) Looks like we have the type annotation wrong (https://github.com/cypress-io/cypress/blob/develop/cli/types/index.d.ts#L2491) . This is part of chai and is documented to only accept a RegExp (https://www.chaijs.com/api/bdd/#method_match). This follows the String. prototype.match signature (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/match) . For matching a substring, you can use include instead: <span>cy</span>.<span>wrap</span>(<span><span>'</span>hello world<span>'</span></span>).<span>should</span>(<span><span>'</span>include<span>'</span></span>, <span><span>'</span>wolrd<span>'</span></span>) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (#2578 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AB6Lhu4f08VIL3PlMlNzLxa4X77fCRWuks5ujNMzgaJpZM4XSe9u) .

[Manishku99251]

Hi I am learning Cypress and new to it just wanted to know how can I achieve the Following
: want to check the font-family value of the button but match is expexcting a Regexp

it('finds the Submit Button and Submits it', function(){

      cy.get('input[type="submit"]').should('have.css','font-family').and('match','inherit')

     cy.get('input[type="submit"]').click().then((submitobj)=>{

         //cy.get(obj).should('have.value')
         expect(submitobj).to.have.value('LOGIN')
     })

  })

[Akxe]

Either use .and('match', /inherit/), or I think there is contain keyword.

[Manishku99251]

@Akxe I am still unable to make it work could you please give an example or something. my requirement is like to match something with the url? eg. cy.url().should('match','/adfs/ls/')

[jennifer-shehane]

@Manishku99251 This annotation for using cypress is correct - cy.url().should('match','/login/'), I would suggest using a regexp checker to determine how to write the regexp against what you want to check.

[cypress-bot]

The code for this is done in cypress-io/cypress#3787, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 3.3.0.