Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress does not correctly terminate SSE connection leaving SSE connections to accumulate on server for duration of run. #2612

Closed
jennifer-shehane opened this issue Oct 15, 2018 · 2 comments · Fixed by #2802
Closed

Cypress does not correctly terminate SSE connection leaving SSE connections to accumulate on server for duration of run. #2612

jennifer-shehane opened this issue Oct 15, 2018 · 2 comments · Fixed by #2802
Assignees
@brian-mann
Milestone
Sprint 11

Comments

@jennifer-shehane
Copy link
Member

Is this a Feature or Bug?

Bug

Current behavior:

We are currently experiencing serious issues with SSEs on Cypress. We
suspect that the Cypress proxy implementation has a bug that is holding
connections for the entire duration of the test run causing SSE connections
to accumulate on the server. We have clearly reproduced this and
consistently confirmed the behaviour.

Steps to reproduce:

See instructions in the README of repo below.

https://github.com/hally9k/cypress-sse

Previous older issue with SSE here: #1440

Versions

Cypress 3.1.0
@jennifer-shehane jennifer-shehane added this to the Sprint 7 milestone Oct 15, 2018
@jennifer-shehane jennifer-shehane added the stage: needs investigating Someone from Cypress needs to look at this label Oct 15, 2018
@trydionel trydionel removed this from the Sprint 7 milestone Oct 22, 2018
@trydionel trydionel added this to the Sprint 8 milestone Oct 22, 2018
@jennifer-shehane jennifer-shehane modified the milestones: Sprint 8, Sprint 10 Nov 5, 2018
@jennifer-shehane jennifer-shehane modified the milestones: Sprint 10, Sprint 11 Nov 13, 2018
@brian-mann
Copy link
Member

I'm looking into how difficult this will be to fix and release with 3.1.2

@brian-mann brian-mann mentioned this issue Nov 19, 2018
Merged
@brian-mann
Copy link
Member

Released in 3.1.2.

@jennifer-shehane jennifer-shehane removed the stage: needs investigating Someone from Cypress needs to look at this label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mann brian-mann

Labels
None yet
Projects
None yet
Milestone
Sprint 11
Development

Successfully merging a pull request may close this issue.

ensure aborted requests are propagated forward cypress-io/cypress
5 participants
@trydionel @chrisbreiding @brian-mann @jennifer-shehane @lilaconlee