Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump progress to 2.0.1 #2733

Merged
merged 2 commits into from Nov 8, 2018
Merged

fix: bump progress to 2.0.1 #2733

merged 2 commits into from Nov 8, 2018

Conversation

thisislawatts
Copy link
Contributor

Some organisations can not work with software which includes unlicensed packages.
I have bumped Progress to the latest version, which introduced an MIT license to the project.

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2018

CLA assistant check
All committers have signed the CLA.

@jennifer-shehane
Copy link
Member

Although this is bumping to a major new version, I'm not seeing any indication from progress's that this was a breaking change in any way: https://github.com/visionmedia/node-progress/blob/master/CHANGELOG.md

@jennifer-shehane
Copy link
Member

@thisislawatts It looks like we're actually not even using this dependency 😳

We updated this PR to remove the dependency references in our package.json that was no longer being used.

@jennifer-shehane jennifer-shehane merged commit a22907a into cypress-io:develop Nov 8, 2018
@brian-mann
Copy link
Member

brian-mann commented Nov 19, 2018

Released in 3.1.2.

@thisislawatts
Copy link
Contributor Author

🎉 That's great. Thank you @bkucera, @brian-mann and @jennifer-shehane

@thisislawatts thisislawatts deleted the fix/bump-progress-to-2.0.1 branch November 19, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants