Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non english characters (Korean) encoding is broken #3479

Closed
say8425 opened this issue Feb 15, 2019 · 7 comments · Fixed by #4698
Closed

Non english characters (Korean) encoding is broken #3479

say8425 opened this issue Feb 15, 2019 · 7 comments · Fixed by #4698
Assignees

Comments

@say8425
Copy link

say8425 commented Feb 15, 2019

cypress-screenshot
Hello. My cypress test is works very well in local. But on the CircleCI, all of non english characters(Korean, hangul, 한글) are broke out. So I change browser from electron to chrome69 browser but it was broke out again. Is this issue caused by the CircleCI machine? or Cypress Orb browser? Thanks.

@jennifer-shehane jennifer-shehane transferred this issue from cypress-io/circleci-orb Feb 15, 2019
@jennifer-shehane
Copy link
Member

Hey @say8425, could you provide a reproducible example?

When I paste in these characters, I am able to see them render in Electron and Chrome, so I cannot reproduce.

Do you have use any special encoding on the html?
Do you have the proper fonts installed on your container?

@jennifer-shehane jennifer-shehane added the stage: needs information Not enough info to reproduce the issue label Feb 15, 2019
@bahmutov
Copy link
Contributor

I think this is the problem with fonts missing on Linux

@junghanChoi
Copy link

junghanChoi commented Apr 10, 2019

Some Korean web pages uses euc-kr Encoding.
I visited "https://news.naver.com" using cypress.
The encoding was broken.
"https://www.naver.com" is fine.
at naver.com, I clicked a text link to news.naver.com. and then it stucked at page load status.
"https://m.news.naver.com" is also fine.

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Apr 18, 2019

Thank you @junghanChoi, this site does exhibit the problem with the encoding.

<meta charset="euc-kr">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<script type="text/javascript" src="..." charset="euc-kr"></script> // some scripts
content-language: ko-KR
content-type: text/html;charset=EUC-KR

Visiting https://news.naver.com/ within Cypress browser (any browser)

Screen Shot 2019-04-18 at 2 00 12 PM

Visiting https://news.naver.com/ outside of Cypress

Screen Shot 2019-04-18 at 2 00 01 PM

Haven't tracked down what the difference is. I do see some of the Request headers in a different caps within Cypress vs outside.

@cypress-bot cypress-bot bot added stage: needs investigating Someone from Cypress needs to look at this and removed stage: needs information Not enough info to reproduce the issue labels Apr 18, 2019
@jennifer-shehane jennifer-shehane changed the title Non english characters are broken Non english characters (Korean) encoding is broken Apr 18, 2019
@junghanChoi
Copy link

Is it possible to add supported language of chrome runner in cypress?
I tried to add Korean in language setting in the chrome which opened by cypress. But It seemed not possible.

@flotwig flotwig self-assigned this Jul 12, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs investigating Someone from Cypress needs to look at this stage: work in progress labels Jul 12, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 15, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 15, 2019

The code for this is done in cypress-io/cypress#4698, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2019

Released in 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants