Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples to cy.location and should "contain" JSDocs #3684

Closed
bahmutov opened this issue Mar 11, 2019 · 2 comments · Fixed by #4702
Closed

Add examples to cy.location and should "contain" JSDocs #3684

bahmutov opened this issue Mar 11, 2019 · 2 comments · Fixed by #4702
Assignees
@bahmutov
Labels
good first issue Good for newcomers topic: typescript

Comments

@bahmutov
Copy link
Contributor

Cypress 3.1.5

In our index.d.ts for types we should add better examples to cy.location and should('contain') to show how to check location url. Something like this for both places

cy.get('.nav-tutorials').click()
cy.location('href').should('contain', '/tag/tutorials/')
@bahmutov bahmutov self-assigned this Mar 11, 2019
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Mar 19, 2019
@jennifer-shehane jennifer-shehane mentioned this issue Jul 12, 2019
Merged
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Jul 12, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 12, 2019

The code for this is done in cypress-io/cypress#4702, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 12, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2019

Released in 3.4.1.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahmutov bahmutov

Labels
good first issue Good for newcomers topic: typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add example for location.href - also should example cypress-io/cypress
2 participants
@jennifer-shehane @bahmutov