Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cy.type('{insert}') is not supported #3845

Closed
fr0 opened this issue Mar 28, 2019 · 4 comments · Fixed by #3892
Closed

cy.type('{insert}') is not supported #3845

fr0 opened this issue Mar 28, 2019 · 4 comments · Fixed by #3892
Labels
good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory topic: cy.type ⌨️ type: feature New feature that does not currently exist

Comments

@fr0
Copy link

fr0 commented Mar 28, 2019

Current behavior:

CypressError: Special character sequence: '{insert}' is not recognized. Available sequences are: {selectall}, {del}, {backspace}, {esc}, {{}, {enter}, {leftarrow}, {rightarrow}, {uparrow}, {downarrow}, {home}, {end}, {alt}, {option}, {ctrl}, {control}, {meta}, {command}, {cmd}, {shift}

Desired behavior:

{insert} should be a supported key. Not sure why it isn't. For that matter, {pageup} and {pagedown} should also be supported.

Versions

3.2.0
@jennifer-shehane jennifer-shehane added type: feature New feature that does not currently exist topic: cy.type ⌨️ pkg/driver This is due to an issue in the packages/driver directory labels Mar 29, 2019
@jennifer-shehane
Copy link
Member

Here's the most recent PR adding support for the {home} and {end} chars. It should help anyone wanting to get started adding support for these chars as well. #3071

@jennifer-shehane jennifer-shehane added stage: ready for work The issue is reproducible and in scope good first issue Good for newcomers labels Mar 29, 2019
@desfero
Copy link
Contributor

desfero commented Apr 2, 2019 •
edited

@jennifer-shehane why we don't allow putting Unicode key codes inside curly braces like this

cy.get('...').type('This is page up {33}')

(https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/which) or even better with

cy.get('...').type('This is page up {PageUp}')

(https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key)

@clarmso clarmso mentioned this issue Apr 5, 2019
Merged
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress stage: needs review The PR code is done & tested, needs review labels Apr 8, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Apr 10, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 10, 2019

The code for this is done in cypress-io/cypress#3892, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

jennifer-shehane pushed a commit that referenced this issue Apr 10, 2019
@clarmso @jennifer-shehane
#3845 Attempt to add insert, page up and page down keys (#3892)
6e5ff7d 
* Attempt to add insert, page up and page down keys.

* Fix keyboard event for page down. Fix tests' titles.

* Fix the pagedown test.

* Fix comment for the insert key.
laurinenas pushed a commit to laurinenas/cypress that referenced this issue Apr 28, 2019
@clarmso @laurinenas
cypress-io#3845 Attempt to add insert, page up and page down keys (cy…
948d3c1 
…press-io#3892)

* Attempt to add insert, page up and page down keys.

* Fix keyboard event for page down. Fix tests' titles.

* Fix the pagedown test.

* Fix comment for the insert key.
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 17, 2019

Released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory topic: cy.type ⌨️ type: feature New feature that does not currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3845 Attempt to add insert, page up and page down keys
3 participants
@fr0 @jennifer-shehane @desfero