Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browsers with spaces in the path name cannot be launched from --browser #3979

Closed
flotwig opened this issue Apr 16, 2019 · 2 comments · Fixed by #4011
Closed

Browsers with spaces in the path name cannot be launched from --browser #3979

flotwig opened this issue Apr 16, 2019 · 2 comments · Fixed by #4011
Assignees
@flotwig
Labels
pkg/launcher This is due to an issue in the packages/launcher directory type: bug

Comments

@flotwig
Copy link
Contributor

flotwig commented Apr 16, 2019

The --browser=<path> option introduced in #1026 does not work properly if the path includes spaces. The spaces will not be properly escaped when doing the --version call, but will be escaped when launching the actual browser, making it impossible to both detect and launch a browser whose path contains spaces.

Workaround: create a symlink that does not contain spaces to the browser, and use that as the path.
@flotwig flotwig added type: bug pkg/launcher This is due to an issue in the packages/launcher directory labels Apr 16, 2019
@flotwig flotwig self-assigned this Apr 16, 2019
@flotwig flotwig changed the title Browsers with spaces in the path name cannot be launched from --browser Browsers with spaces in the path name cannot be launched from --browser Apr 16, 2019
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Apr 18, 2019
@flotwig flotwig mentioned this issue Apr 22, 2019
Merged
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress stage: needs review The PR code is done & tested, needs review labels Apr 22, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels May 15, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 15, 2019

The code for this is done in cypress-io/cypress#4011, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 17, 2019

Released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flotwig flotwig

Labels
pkg/launcher This is due to an issue in the packages/launcher directory type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape paths passed by --browser cypress-io/cypress
1 participant
@flotwig