Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate possible slowness in getFirstWorkingFamily/cy.visit() #4349

Closed
flotwig opened this issue May 30, 2019 · 3 comments
Closed

Investigate possible slowness in getFirstWorkingFamily/cy.visit() #4349

flotwig opened this issue May 30, 2019 · 3 comments
Assignees
Labels
topic: network type: duplicate This issue or pull request already exists type: performance 🏃‍♀️ Performance related

Comments

@flotwig
Copy link
Contributor

flotwig commented May 30, 2019

return getFirstWorkingFamily(options, this.familyCache, (family: net.family) => {
options.family = family
if (isHttps) {
return this.httpsAgent.addRequest(req, options)
}
this.httpAgent.addRequest(req, options)
})

This can add up to a second to the initial request to a domain, and we need to double-check that this is all network latency and there's nothing untoward going on here.

@flotwig flotwig self-assigned this May 30, 2019
@cypress-bot cypress-bot bot added the stage: needs investigating Someone from Cypress needs to look at this label May 31, 2019
@flotwig flotwig changed the title Investigate possible slowness in getFirstWorkingFamily Investigate possible slowness in getFirstWorkingFamily/cy.visit() Jun 3, 2019
@flotwig flotwig mentioned this issue Jun 3, 2019
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs investigating Someone from Cypress needs to look at this labels Jun 3, 2019
@flotwig
Copy link
Contributor Author

flotwig commented Jun 4, 2019

Duplicate of #4313

@flotwig flotwig marked this as a duplicate of #4313 Jun 4, 2019
@flotwig flotwig closed this as completed Jun 4, 2019
@flotwig flotwig added type: duplicate This issue or pull request already exists and removed stage: work in progress labels Jun 4, 2019
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jun 4, 2019
@jennifer-shehane jennifer-shehane added stage: pending release and removed stage: ready for work The issue is reproducible and in scope labels Jun 19, 2019
@flotwig flotwig reopened this Jun 27, 2019
@flotwig
Copy link
Contributor Author

flotwig commented Jun 27, 2019

Is this actually happening? Got lost in the blur of other performance changes.

@jennifer-shehane
Copy link
Member

Closing as resolved in 3.3.2

If you're experiencing a bug similar to this in Cypress, please open a new issue with a fully reproducible example that we can run. There may be a specific edge case with the issue that we need more detail to fix.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: network type: duplicate This issue or pull request already exists type: performance 🏃‍♀️ Performance related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants